Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js

Summary

Maintainability
D
2 days
Test Coverage

File jpeg-compression.js has 508 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const Interact = require('interactjs');
var urlParameters = require('../../../js/third-party/url-parameters.js');
require('./../../../js/third-party/jquery.stepper');
const dct = require('dct');
Severity: Major
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js - About 1 day to fix

Function createDCTTable has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function createDCTTable() {

        for (var i = 1; i <= 8; i++) {
            var row = $("<tr></tr>");
            for (var j = 1; j <= 8; j++) {
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js - About 1 hr to fix

Function dragSmallSquare has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function dragSmallSquare() {
        // target elements with the "draggable" class
        Interact('.draggable')
            .draggable({
                // enable inertial throwing
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js - About 1 hr to fix

Avoid too many return statements within this function.
Open

        return true;
Severity: Major
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (var i = 0; i < pixels.length; i += 1) {
            if ((i + 1) % 4 == 0) {
                pixels[i] = 255;
                index++;
            } else {
Severity: Major
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js on lines 102..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for (var i = 0; i < pixels.length; i += 1) {
                if ((i + 1) % 4 == 0) {
                    pixels[i] = 255;
                    index++;
                } else {
Severity: Major
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js on lines 577..584

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $("#toggleNumberBefore").change(function () {
        $("#before-labels-8-by-8").toggle("fade");
        $("#after-labels-8-by-8").toggle("fade");
    });
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 40 mins to fix
csfieldguide/static/js/website-search.js on lines 9..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            target.style.webkitTransform =
                target.style.transform =
                    'translate(' + x + 'px, ' + y + 'px)';
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/bin-packing/js/bin-packing.js on lines 251..253

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            var y = Math.max(Math.floor((parseFloat(target.getAttribute('data-y')) || 0) + event.dy), 0);
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js on lines 500..500

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            var x = Math.max(Math.floor((parseFloat(target.getAttribute('data-x')) || 0) + event.dx), 0);
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js on lines 501..501

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                var y = 0.299 * data[i] + 0.587 * data[i + 1] + 0.114 * data[i + 2];
Severity: Minor
Found in csfieldguide/static/interactives/jpeg-compression/js/jpeg-compression.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/viola-jones-face-detector/js/viola-jones.js on lines 342..342

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status