Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js

Summary

Maintainability
F
1 wk
Test Coverage

File matrix-simplifier.js has 510 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const dragula = require('dragula');
const mathjs_import = require('mathjs');
const sprintf = require('sprintf-js').sprintf;
const vsprintf = require('sprintf-js').vsprintf;
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 1 day to fix

Function appendInput has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function appendInput(type, inputHtml) {
  var $newContainerDiv = $("<div>").addClass('draggable content border rounded m-1 center-block');
  var $newInputDiv = $("<div>").addClass('invisible ' + type);
  var $moveLabel = $('<span class="close move-eqtn" aria-label="Move">');
  $moveLabel.append(DRAGGER_SVG.clone());
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 1 hr to fix

Function updateEquation has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updateEquation(eqtnDiv, orderIndex) {
  if (eqtnDiv.hasClass('matrix')) {
    // inputs get evaluated as math
    matrixArrayMath = getMatrix(true);
    // inputs remain as strings for display
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 1 hr to fix

Function getMatrix has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getMatrix(evalAsMath) {
  if (evalAsMath){
    row0 = [
      mathjs.evaluate($('#matrix-row-0-col-0').val()),
      mathjs.evaluate($('#matrix-row-0-col-1').val()),
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 1 hr to fix

Function dismissEquation has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function dismissEquation() {
  eqtnToRemove = $(this).next().next(); // div of matrix/vector to remove
  if (eqtnToRemove.hasClass('matrix')) {
    orderIndex = eqtnToRemove.attr('data-matrix-order');
    // remove from order array
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 1 hr to fix

Function populateModalForEditing has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function populateModalForEditing() {
  eqtnToEdit = $(this).next(); // div of matrix/vector to edit
  if (eqtnToEdit.hasClass('matrix')) {
    $('#matrix-modal-title').html(gettext("Update matrix"));
    // replace add button with edit button in modal
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 1 hr to fix

Function dismissEquation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function dismissEquation() {
  eqtnToRemove = $(this).next().next(); // div of matrix/vector to remove
  if (eqtnToRemove.hasClass('matrix')) {
    orderIndex = eqtnToRemove.attr('data-matrix-order');
    // remove from order array
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  } else {
    var matrixNum = currentMatricesOrder.length - 1;
    $closeButton.attr('id', 'close-matrix-' + matrixNum);
    $editButton.attr('id', 'edit-matrix-' + matrixNum);
    $editButton.attr('data-toggle', 'modal');
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 6 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 205..215

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (type == 'vector') {
    var vectorNum = currentVectorsOrder.length - 1;
    $closeButton.attr('id', 'close-vector-' + vectorNum);
    $editButton.attr('id', 'edit-vector-' + vectorNum);
    $editButton.attr('data-toggle', 'modal');
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 6 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 215..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  } else {
    row0 = [
      $('#matrix-row-0-col-0').val(),
      $('#matrix-row-0-col-1').val(),
      $('#matrix-row-0-col-2').val(),
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 5 hrs to fix
csfieldguide/static/interactives/scene-editor/js/scene-editor.js on lines 702..721

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 135.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function multiplyMatrices(m) {
  var multiply = true;
  while (multiply) {
    if (m.length == 2) {
      multiply = false;
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 4 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 376..390

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function addVectors(v) {
  var add = true;
  while (add) {
    if (v.length == 2) {
      add = false;
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 4 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 356..370

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 126.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  $('#copy-eqtn').click(function() {
    $('#code-to-copy').select();
    try {
      var successful = document.execCommand('copy');
      if (successful) {
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 2 other locations - About 4 hrs to fix
csfieldguide/static/interactives/rsa-key-generator/js/rsa-key-generator.js on lines 42..54
csfieldguide/static/interactives/rsa-key-generator/js/rsa-key-generator.js on lines 56..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 122.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

fns1.forEach(function(name) {
  const fn = mathjs[name]; // the original function

  const fnNumber = function (x) {
    // convert from degrees to radians
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 4 hrs to fix
csfieldguide/static/interactives/scene-editor/js/scene-editor.js on lines 63..78

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $('div[data-matrix-order]').each(function() {
      order = $(this).attr('data-matrix-order');
      if (order > orderIndex) {
        newOrder = order - 1;
        $(this).attr('data-matrix-order', newOrder);
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 565..571

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $('div[data-vector-order]').each(function() {
      order = $(this).attr('data-vector-order');
      if (order > orderIndex) {
        newOrder = order - 1;
        $(this).attr('data-vector-order', newOrder);
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 546..552

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  vectorArrayMath = [
    [mathjs.evaluate($('#vector-row-0').val())],
    [mathjs.evaluate($('#vector-row-1').val())],
    [mathjs.evaluate($('#vector-row-2').val())]
  ];
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 649..653

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    vectorArrayMath = [
      [mathjs.evaluate($('#vector-row-0').val())],
      [mathjs.evaluate($('#vector-row-1').val())],
      [mathjs.evaluate($('#vector-row-2').val())]
    ];
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 158..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (currentVectorsOrder.length == 1) {
    vectorResult = currentVectorsOrder[0];
  } else if (currentVectorsOrder.length > 1) {
    // 2 or more vectors
    vectorsCopy = currentVectorsOrder.slice(); // copy list for adding in place
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 333..339

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  if (currentMatricesOrder.length == 1) {
    matrixResult = currentMatricesOrder[0];
  } else if (currentMatricesOrder.length > 1) {
    // 2 or more matrices
    matricesCopy = currentMatricesOrder.slice(); // copy list for multiplying in place
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 341..347

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  $('[data-toggle="tooltip"]').on('copied', function(event, message) {
    $(this).attr('title', message)
      .tooltip('_fixTitle')
      .tooltip('show')
      .attr('title', TXT_COPY)
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/rsa-key-generator/js/rsa-key-generator.js on lines 70..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    row2 = [
      mathjs.evaluate($('#matrix-row-2-col-0').val()),
      mathjs.evaluate($('#matrix-row-2-col-1').val()),
      mathjs.evaluate($('#matrix-row-2-col-2').val()),
    ];
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 2 other locations - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 238..242
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 244..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    row0 = [
      mathjs.evaluate($('#matrix-row-0-col-0').val()),
      mathjs.evaluate($('#matrix-row-0-col-1').val()),
      mathjs.evaluate($('#matrix-row-0-col-2').val()),
    ];
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 2 other locations - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 244..248
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 250..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    row1 = [
      mathjs.evaluate($('#matrix-row-1-col-0').val()),
      mathjs.evaluate($('#matrix-row-1-col-1').val()),
      mathjs.evaluate($('#matrix-row-1-col-2').val()),
    ];
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 2 other locations - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 238..242
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 250..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function removeAllVectors() {
  $(".vector").parent().remove();
  currentVectorsOrder = [];
  vectorsStringFormat = [];
  $('#remove-all-vectors').attr('disabled', true);
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 707..714

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function removeAllMatrices() {
  $(".matrix").parent().remove();
  currentMatricesOrder = [];
  matricesStringFormat = [];
  $('#remove-all-matrices').attr('disabled', true);
Severity: Major
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 718..725

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  vectorArrayString = [
    [$('#vector-row-0').val()],
    [$('#vector-row-1').val()],
    [$('#vector-row-2').val()]
  ];
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 50 mins to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 655..659

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    vectorArrayString = [
      [$('#vector-row-0').val()],
      [$('#vector-row-1').val()],
      [$('#vector-row-2').val()]
    ];
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 50 mins to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 164..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (eqtnDiv.hasClass('matrix')) {
        var siblingOrder = currentMatricesOrder.length - 1; // because it's last in order
        var siblingDiv = $("div").find("[data-matrix-order='" + siblingOrder + "']");
      } else {
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 40 mins to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 448..451

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      } else {
        var siblingOrder = currentVectorsOrder.length - 1; // because it's last in order
        var siblingDiv = $("div").find("[data-vector-order='" + siblingOrder + "']");
      }
Severity: Minor
Found in csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js and 1 other location - About 40 mins to fix
csfieldguide/static/interactives/matrix-simplifier/js/matrix-simplifier.js on lines 445..448

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status