Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js

Summary

Maintainability
F
5 days
Test Coverage

File product-code-check-digit-calculation.js has 657 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const JsBarcode = require('jsbarcode');
const arrowSVG = require('arrows-svg');
const arrowCreate = arrowSVG.default;
const arrowDirections = arrowSVG.DIRECTION;
const arrowHeads = arrowSVG.HEAD;
Severity: Major
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 day to fix

Function setupStepTwo has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupStepTwo(event) {
    stepNumber = 2;
    // Disable all step one buttons
    let elementButtonContainer = document.getElementById(buttonContainerID);
    for (let i = 0; i < elementButtonContainer.children.length; i++) {
Severity: Major
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 3 hrs to fix

Function checkThirdRowInputs has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

function checkThirdRowInputs(event) {

    let correctValues = 0;
    for (let i = 0; i < (productCodeTopRowInputElements.length); i++) {
        let topInputElement = productCodeTopRowInputElements[i];
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setupStepThree has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupStepThree() {
    stepNumber = 3;
    productCodeThirdRowInputElements = [];
    productCodeWeightings = productCodeData[productCodeSlug].weightings;
Severity: Major
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 2 hrs to fix

Function setupStepFive has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setupStepFive() {
    // Minus step
    stepNumber = 5;
    calculationGridElement.classList.add('step-five');
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 hr to fix

Function setupStepTwo has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function setupStepTwo(event) {
    stepNumber = 2;
    // Disable all step one buttons
    let elementButtonContainer = document.getElementById(buttonContainerID);
    for (let i = 0; i < elementButtonContainer.children.length; i++) {
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkThirdRowInputs has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function checkThirdRowInputs(event) {

    let correctValues = 0;
    for (let i = 0; i < (productCodeTopRowInputElements.length); i++) {
        let topInputElement = productCodeTopRowInputElements[i];
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 hr to fix

Function updateSubractionResultArrow has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updateSubractionResultArrow() {
    // Clear any existing arrow
    if (subractionResultArrow) {
        subractionResultArrow.clear();
    }
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 hr to fix

Function checkMultiplicationSumInput has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

function checkMultiplicationSumInput(allCorrect) {
    let expectedSum = 0;
    for (let i = 0; i < (productCodeThirdRowInputElements.length); i++) {
        let thirdInputElement = productCodeThirdRowInputElements[i];
        expectedSum += parseInt(thirdInputElement.value);
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkMultiplicationSumInput has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function checkMultiplicationSumInput(allCorrect) {
    let expectedSum = 0;
    for (let i = 0; i < (productCodeThirdRowInputElements.length); i++) {
        let thirdInputElement = productCodeThirdRowInputElements[i];
        expectedSum += parseInt(thirdInputElement.value);
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 1 hr to fix

Function checkSubtractionInput has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function checkSubtractionInput() {
    let correctSum = 10 - parseInt(subtractionValueElement.textContent);
    if (useModulo) {
        correctSum = correctSum % 10;
    }
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateProductCode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function updateProductCode() {
    productCode = '';
    let allInputsFilled = true;
    for (let i = 0; i < (productCodeTopRowInputElements.length); i++) {
        let inputElement = productCodeTopRowInputElements[i];
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processTopRowInputDigit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function processTopRowInputDigit(event) {
    let inputElement = event.target;
    if (inputElement.value.match(/\d{1}/)) {
        inputElement.dataset.lastInput = inputElement.value;
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (subtractionResultElement.value == '') {
        subtractionResultElement.classList.remove('correct', 'incorrect');
    } else if (givenSum == correctSum) {
        subtractionResultElement.classList.add('correct');
        subtractionResultElement.classList.remove('incorrect');
Severity: Major
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js and 1 other location - About 4 hrs to fix
csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js on lines 482..493

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (productCodeThirdRowSumElement.value == '') {
        productCodeThirdRowSumElement.classList.remove('correct', 'incorrect');
    } else if (givenSum == expectedSum) {
        productCodeThirdRowSumElement.classList.add('correct');
        productCodeThirdRowSumElement.classList.remove('incorrect');
Severity: Major
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js and 1 other location - About 4 hrs to fix
csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js on lines 509..520

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function ready(fn) {
    if (document.readyState != 'loading') {
        setup();
    } else {
        document.addEventListener('DOMContentLoaded', setup);
Severity: Minor
Found in csfieldguide/static/interactives/product-code-check-digit-calculation/js/product-code-check-digit-calculation.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/qr-code-generator/js/qr-code-generator.js on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status