Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js

Summary

Maintainability
F
4 days
Test Coverage

Function setColor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RGB_Mixer.setColor = function() {
  // Get the slider values,
  var r_val = RGB_Mixer.sliders[0].noUiSlider.get();
  var g_val = RGB_Mixer.sliders[1].noUiSlider.get();
  var b_val = RGB_Mixer.sliders[2].noUiSlider.get();
Severity: Minor
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js - About 1 hr to fix

Function setColorFromInputBox has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

RGB_Mixer.setColorFromInputBox = function(){
  // Get the slider values,
  red_val = $('#interactive-rgb-mixer-red-value').val() || 0;
  green_val = $('#interactive-rgb-mixer-green-value').val() || 0;
  blue_val = $('#interactive-rgb-mixer-blue-value').val() || 0;
Severity: Minor
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setColorFromInputBox has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RGB_Mixer.setColorFromInputBox = function(){
  // Get the slider values,
  red_val = $('#interactive-rgb-mixer-red-value').val() || 0;
  green_val = $('#interactive-rgb-mixer-green-value').val() || 0;
  blue_val = $('#interactive-rgb-mixer-blue-value').val() || 0;
Severity: Minor
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js - About 1 hr to fix

Function setColor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

RGB_Mixer.setColor = function() {
  // Get the slider values,
  var r_val = RGB_Mixer.sliders[0].noUiSlider.get();
  var g_val = RGB_Mixer.sliders[1].noUiSlider.get();
  var b_val = RGB_Mixer.sliders[2].noUiSlider.get();
Severity: Minor
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

$("input[name='interactive-rgb-mixer-colourCode']").click(function() {
  var temp = $("input[name='interactive-rgb-mixer-colourCode']:checked").val() == 'hex';
  if (temp != useHex) {
    useHex = temp;
    var r_val = $('#interactive-rgb-mixer-red-value').val() || 0;
Severity: Major
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js and 1 other location - About 3 days to fix
csfieldguide/static/interactives/cmy-mixer/js/cmy-mixer.js on lines 71..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 526.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  for ( var i = 0; i < RGB_Mixer.sliders.length; i++ ) {
    noUiSlider.create(RGB_Mixer.sliders[i], {
      start: Math.floor(Math.random() * RGB_Mixer.maximum),
      step: 1,
      connect: "lower",
Severity: Major
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js and 1 other location - About 6 hrs to fix
csfieldguide/static/interactives/cmy-mixer/js/cmy-mixer.js on lines 36..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function getFontColour(r, g, b) {
  // http://www.w3.org/TR/AERT#color-contrast
  var brightness = Math.round(((parseInt(r) * 299) +
                      (parseInt(g) * 587) +
                      (parseInt(b) * 114)) / 1000);
Severity: Major
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/cmy-mixer/js/cmy-mixer.js on lines 225..232

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 86.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

const sFormat = {
  to: function (value) {
    if (useHex) {
      return decimalToHex(Math.round(value));
    }
Severity: Major
Found in csfieldguide/static/interactives/rgb-mixer/js/rgb-mixer.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/cmy-mixer/js/cmy-mixer.js on lines 7..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status