Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/training-ground/js/training-ground.js

Summary

Maintainability
D
2 days
Test Coverage

File training-ground.js has 498 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * trAIning ground
 * 
 * Creates and executes the game
 */
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 7 hrs to fix

Function createSliders has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createSliders() {
  whoStartsRange = document.getElementById('who-starts-select');
  noUiSlider.create(whoStartsRange, {
    range: {
      'min': 0,
Severity: Major
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 4 hrs to fix

Function runQuickSimulation has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function runQuickSimulation(num) {
  var aiTurn;
  var choice;
  while (num > 0) {
    ai.newGame();
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function runQuickSimulation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function runQuickSimulation(num) {
  var aiTurn;
  var choice;
  while (num > 0) {
    ai.newGame();
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 1 hr to fix

Function endGame has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function endGame(winner) {
  gamesPlayed++;
  displayBaseVariables();
  if (winner == PLAYERS.AI) {
    aiWins++;
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 1 hr to fix

Function readyPlayerTurn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function readyPlayerTurn() {
  var num;
  if (remainingSticks <= 0) {
    // The AI won
    endGame(PLAYERS.AI);
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function takeAiTurn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function takeAiTurn() {
  if (remainingSticks <= 0) {
    // The Player/Practice bot won, doesn't matter which bot
    endGame(isSimulation ? PLAYERS.INTELLIBOT : PLAYERS.HUMAN);
  } else {
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function endGame has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function endGame(winner) {
  gamesPlayed++;
  displayBaseVariables();
  if (winner == PLAYERS.AI) {
    aiWins++;
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getParameters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function getParameters() {
  var chanceOfAiStart = whoStartsRange.noUiSlider.get();
  if (chanceOfAiStart == TXT_AI_ALWAYS) {
    chanceOfPlayerStart = 0;
  } else if (chanceOfAiStart == TXT_PLAYER_ALWAYS) {
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function applyMove has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function applyMove(player, numChosen) {
  if (player == PLAYERS.AI) {
    if (!isSimulation) {
      sticksGrid.removeSticks(numChosen);
    }
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function enableChoiceButtons() {
  $('#button_1').prop('disabled', false);
  $('#button_2').prop('disabled', false);
  $('#button_3').prop('disabled', false);
}
Severity: Major
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/training-ground/js/training-ground.js on lines 564..568

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function disableChoiceButtons() {
  $('#button_1').prop('disabled', true);
  $('#button_2').prop('disabled', true);
  $('#button_3').prop('disabled', true);
}
Severity: Major
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/training-ground/js/training-ground.js on lines 574..578

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function hideCancelButtons() {
  $('#button_cancel').addClass('d-none').prop('disabled', true);
  $('#button_modal_cancel').addClass('d-none').prop('disabled', true);
}
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js and 1 other location - About 50 mins to fix
csfieldguide/static/interactives/training-ground/js/training-ground.js on lines 651..654

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function showCancelButtons() {
  $('#button_cancel').removeClass('d-none').prop('disabled', false);
  $('#button_modal_cancel').removeClass('d-none').prop('disabled', false);
}
Severity: Minor
Found in csfieldguide/static/interactives/training-ground/js/training-ground.js and 1 other location - About 50 mins to fix
csfieldguide/static/interactives/training-ground/js/training-ground.js on lines 643..646

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status