Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js

Summary

Maintainability
F
5 days
Test Coverage

File translation-rotation.js has 480 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Common source code for the box translation and rotation interactives
 */

var THREE = require('three');
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 7 hrs to fix

Function updateCoords has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

function updateCoords(axis, change) {

    if (axis == 'x') {
        if (change == '-') {
            x_pos = (x_pos - difference);
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function initHandlers has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function initHandlers() {
    $('#restart-button').on('click', function() {
        reset();
    });
    $('#desk-x-coordinate').on('click', function() {
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 3 hrs to fix

Function updateCoords has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updateCoords(axis, change) {

    if (axis == 'x') {
        if (change == '-') {
            x_pos = (x_pos - difference);
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 2 hrs to fix

Function incorrect has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function incorrect() {

    updateCoords(); //checks for if user clicks "Check Code" without changing coordinates

    var target;
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 1 hr to fix

Function buildCube has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function buildCube() {

    // creates a box with sides of length 200
    var geometry = new THREE.BoxGeometry(200, 200, 200);
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 1 hr to fix

Function init has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function init() {

    // Is this the translation or rotation interactive?
    isTranslationInter = container.classList.contains('box-translation');
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 1 hr to fix

Function limiter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function limiter(pos) {
    if (isTranslationInter) {
        if (pos < -360) {
            return -360;
        } else if (pos > 360) {
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return pos % 360;
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 30 mins to fix

Function submitCode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

function submitCode() {


    if (code[1] == boxSymbols['left_side']) {
        if (code[2] == boxSymbols['bottom_side']) {
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else {
        if (change == '-') {
            z_pos = (z_pos - difference);
        } else if (change == '+') {
            z_pos = (z_pos + difference);
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 6 hrs to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 232..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else if (axis == 'y') {
        if (change == '-') {
            y_pos = (y_pos - difference);
        } else if (change == '+') {
            y_pos = (y_pos + difference);
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 6 hrs to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 248..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (code[1] == null) {
        code[1] = selectedSymbolId;
        document.getElementById('first-symbol').src = img_src;
        // replace left with grayscale
        updateSide(1,  boxSymbols['left_side'], false);
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 1 hr to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 294..304

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    } else if (code[2] == null) {
        code[2] = selectedSymbolId;
        document.getElementById('second-symbol').src = img_src;
        // replace bottom with grayscale
        updateSide(3,  boxSymbols['bottom_side'], false);
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 1 hr to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 287..304

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        new TWEEN.Tween(cube.position)
            .to(target, 1000)
            .easing(TWEEN.Easing.Back.Out)
            .start();
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 45 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 441..444

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    new TWEEN.Tween(camera.position)
        .to(target, 2000)
        .easing (TWEEN.Easing.Elastic.Out)
        .start();
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 45 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 531..534

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    } else if (isNaN(y_pos)) {
        y_pos = 0;
        document.getElementById('desk-y-coordinate').value = y_pos;
        document.getElementById('mob-y-coordinate').value = y_pos;
    } else if (isNaN(z_pos)){
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 2 other locations - About 40 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 583..595
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 591..595

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    if (isNaN(x_pos)) {
        x_pos = 0;
        document.getElementById('desk-x-coordinate').value = x_pos;
        document.getElementById('mob-x-coordinate').value = x_pos;
    } else if (isNaN(y_pos)) {
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 2 other locations - About 40 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 587..595
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 591..595

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    } else if (isNaN(z_pos)){
        z_pos = 0;
        document.getElementById('desk-z-coordinate').value = z_pos;
        document.getElementById('mob-z-coordinate').value = z_pos;
    }
Severity: Major
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 2 other locations - About 40 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 583..595
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 587..595

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                new TWEEN.Tween(cube.position)
                    .to(target)
                    .easing (TWEEN.Easing.Elastic.Out)
                    .start();
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 35 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 621..624

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    new TWEEN.Tween(camera.position)
        .to(target)
        .easing (TWEEN.Easing.Elastic.Out)
        .onUpdate(render)
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 35 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 393..396

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    $(document).on('keypress', function(key) {
        if(key.which == 13) {
            // Enter was pressed
            runEnterHandler();
        }
Severity: Minor
Found in csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js and 1 other location - About 30 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 341..346

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status