Sign upLogin

ujh/fountainpencompanion

View on GitHub
Star
app/javascript/src/admin/micro-clusters/macroClusters.js

Summary

Maintainability
F
3 days
Test Coverage

Function getMacroClusters has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const getMacroClusters = (dispatch) => {
  let data = [];
  const formatter = new Jsona();
  function run(page = 1) {
    loadMacroClusterPage(page).then((json) => {
Severity: Minor
Found in app/javascript/src/admin/micro-clusters/macroClusters.js - About 1 hr to fix

    Function run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function run(page = 1) {
    loadMacroClusterPage(page).then((json) => {
      const pagination = json.meta.pagination;
      dispatch({
        type: SET_LOADING_PERCENTAGE,
    Severity: Minor
    Found in app/javascript/src/admin/micro-clusters/macroClusters.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      export const getMacroClusters = (dispatch) => {
  let data = [];
  const formatter = new Jsona();
  function run(page = 1) {
    loadMacroClusterPage(page).then((json) => {
      Severity: Major
      Found in app/javascript/src/admin/micro-clusters/macroClusters.js and 2 other locations - About 1 day to fix
      app/javascript/src/admin/pens-micro-clusters/macroClusters.js on lines 14..49
      app/javascript/src/admin/pens-model-micro-clusters/macroClusters.js on lines 14..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 333.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const updateMacroCluster = (id, dispatch) => {
  setTimeout(() => {
    getRequest(`/admins/macro_clusters/${id}.json`)
      .then((response) => response.json())
      .then((json) => {
      Severity: Major
      Found in app/javascript/src/admin/micro-clusters/macroClusters.js and 1 other location - About 1 day to fix
      app/javascript/src/admin/pens-micro-clusters/macroClusters.js on lines 88..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 212.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      const loadMacroClusterPage = async (page) => {
  const response = await getRequest(
    `/admins/macro_clusters.json?per_page=50&page=${page}`
  );
  return await response.json();
      Severity: Major
      Found in app/javascript/src/admin/micro-clusters/macroClusters.js and 3 other locations - About 35 mins to fix
      app/javascript/src/admin/pens-micro-clusters/macroClusters.js on lines 109..114
      app/javascript/src/admin/pens-model-micro-clusters/macroClusters.js on lines 110..113
      app/javascript/src/admin/pens-model-micro-clusters/microClusters.js on lines 80..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status