Sign upLogin

ujh/fountainpencompanion

View on GitHub
Star
app/javascript/src/admin/pens-micro-clusters/microClusters.js

Summary

Maintainability
D
2 days
Test Coverage

Function getMicroClusters has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const getMicroClusters = (dispatch) => {
  const formatter = new Jsona();
  let data = [];
  function run(page = 1) {
    loadMicroClusterPage(page).then((json) => {
Severity: Minor
Found in app/javascript/src/admin/pens-micro-clusters/microClusters.js - About 1 hr to fix

    Function run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function run(page = 1) {
    loadMicroClusterPage(page).then((json) => {
      const pagination = json.meta.pagination;
      dispatch({
        type: SET_LOADING_PERCENTAGE,
    Severity: Minor
    Found in app/javascript/src/admin/pens-micro-clusters/microClusters.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export const getMicroClusters = (dispatch) => {
  const formatter = new Jsona();
  let data = [];
  function run(page = 1) {
    loadMicroClusterPage(page).then((json) => {
      Severity: Major
      Found in app/javascript/src/admin/pens-micro-clusters/microClusters.js and 1 other location - About 1 day to fix
      app/javascript/src/admin/pens-model-micro-clusters/microClusters.js on lines 10..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 303.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        putRequest(`/admins/pens/micro_clusters/${microClusterId}.json`, {
    data: {
      id: microClusterId,
      type: "pens_micro_cluster",
      attributes: { pens_model_variant_id: macroClusterId }
      Severity: Major
      Found in app/javascript/src/admin/pens-micro-clusters/microClusters.js and 2 other locations - About 1 hr to fix
      app/javascript/src/admin/micro-clusters/assignCluster.jsx on lines 5..24
      app/javascript/src/admin/pens-model-micro-clusters/microClusters.js on lines 56..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      export const ignoreCluster = ({ id }) =>
  putRequest(`/admins/pens/micro_clusters/${id}.json`, {
    data: {
      type: "pens_micro_cluster",
      attributes: { ignored: true }
      Severity: Major
      Found in app/javascript/src/admin/pens-micro-clusters/microClusters.js and 2 other locations - About 1 hr to fix
      app/javascript/src/admin/micro-clusters/ignoreCluster.jsx on lines 3..9
      app/javascript/src/admin/pens-model-micro-clusters/microClusters.js on lines 47..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            microCluster.macro_cluster.micro_clusters.forEach((mc) => {
        mc.entries = mc.collected_pens;
        delete mc.collected_pens;
      });
      Severity: Major
      Found in app/javascript/src/admin/pens-micro-clusters/microClusters.js and 2 other locations - About 40 mins to fix
      app/javascript/src/admin/micro-clusters/assignCluster.jsx on lines 18..21
      app/javascript/src/admin/pens-model-micro-clusters/microClusters.js on lines 71..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status