Showing 82 of 377 total issues
Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def index
respond_to do |format|
format.json do
# FIXME: Adding an includes here breaks the serialization and does not include
# the collected pens anymore. This is due to the way the association is- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_comment has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def add_comment
unless changed.any? { |c| %w[brand_name line_name ink_name].include?(c) }
return
end
return unless comment.blank?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"