ultimate-comparisons/ultimate-comparison-BASE

View on GitHub

Showing 5 of 111 total issues

Avoid deeply nested control flow statements.
Open

                                if (a <= numberValue && numberValue <= b) {
                                    includeElement = true;
                                }
Severity: Major
Found in src/app/redux/uc.reducers.ts - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            } else if (splits.length === 2 && splits[0].length > 0 && splits[1].length === 0) {
                                // intermittent range search, something like `250-` inbetween entering valid states
                                a = b = Number.parseInt(splits[0]);
                            } else if (splits.length === 3 && splits[0].length === 0 && splits[2].length === 0) {
                                // intermittent range search, something like `-250-` inbetween entering valid states
    Severity: Major
    Found in src/app/redux/uc.reducers.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (a > b) {
                                      const c = b;
                                      b = a;
                                      a = c;
                                  }
      Severity: Major
      Found in src/app/redux/uc.reducers.ts - About 45 mins to fix

        Consider simplifying this complex logical expression.
        Open

                if ((minDiff >= criteriaValue.minAge || criteriaValue.minAge === undefined || criteriaValue.minAge === -1)
                    && (maxDiff < criteriaValue.maxAge || criteriaValue.maxAge === undefined || criteriaValue.maxAge === -1)) {
                    labels.set(criteriaValue.name, new Label(criteriaValue.name, new Tooltip(criteriaValue.description, ""
                        + "- <" + link + ">"
                        + "\n- Last repository change: " + date.format("YYYY-MM-DDTHH:mm:ss")
        Severity: Major
        Found in lib/gulp/tasks/developmentColumn.babel.js - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

              if ((isNullOrUndefined(type) && id === "id") ||
                (!isNullOrUndefined(type) &&
                  String(type).toUpperCase() === "NAME-URL" ||
                  String(type).toUpperCase() === "NAME_URL" ||
                  String(type).toUpperCase() === "URL")
          Severity: Major
          Found in lib/gulp/model/criteria/criteria.js - About 40 mins to fix
            Severity
            Category
            Status
            Source
            Language