Sign upLogin

unageanu/jiji2

View on GitHub
Star
sites/src/js/view/components/agents/agent-property-editor.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function createEditor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  createEditor() {
    const selectedAgent = this.state.selectedAgent;
    if (selectedAgent == null) return null;

    const agentClass =  this.props.model.getAgentClassForSelected();
Severity: Minor
Found in sites/src/js/view/components/agents/agent-property-editor.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const configuration = agentClass.properties.reduce((r, p) => {
      r[p.id] = this.refs["agent_properties_" + p.id].getValue();
      return r;
    }, {});
    Severity: Minor
    Found in sites/src/js/view/components/agents/agent-property-editor.js and 1 other location - About 50 mins to fix
    sites/src/js/view/components/settings/securities-setting-view.js on lines 117..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
    Open

    import React                  from "react"
    Severity: Minor
    Found in sites/src/js/view/components/agents/agent-property-editor.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status