Sign upLogin

unageanu/jiji2

View on GitHub
Star
sites/src/js/viewmodel/pages/login-page-model.js

Summary

Maintainability
C
7 hrs
Test Coverage

LoginPageModel has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class LoginPageModel extends AbstractPageModel {

  constructor() {
    super();
    this.authenticator            = ContainerJS.Inject;
Severity: Minor
Found in sites/src/js/viewmodel/pages/login-page-model.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        }, (error)  => {
      if (error.code == Error.Code.INVALID_VALUE) {
        this.passwordResettingError =
          "パスワードの再設定に失敗しました。トークンを確認してください。";
        error.preventDefault = true;
    Severity: Major
    Found in sites/src/js/viewmodel/pages/login-page-model.js and 1 other location - About 1 hr to fix
    sites/src/js/viewmodel/pages/login-page-model.js on lines 55..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        }, (error)  => {
      if (error.code == Error.Code.UNAUTHORIZED) {
        this.error = "パスワードが一致していません";
        error.preventDefault = true;
      }
    Severity: Major
    Found in sites/src/js/viewmodel/pages/login-page-model.js and 1 other location - About 1 hr to fix
    sites/src/js/viewmodel/pages/login-page-model.js on lines 105..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      validateMailAddress(mailAddress) {
    return ValidationUtils.validate(Validators.mailAddress, mailAddress,
      {field: "メールアドレス"}, (error) => this.resettinMailSendingError = error );
  }
    Severity: Major
    Found in sites/src/js/viewmodel/pages/login-page-model.js and 3 other locations - About 30 mins to fix
    sites/src/js/viewmodel/agents/agent-source-editor.js on lines 83..86
    sites/src/js/viewmodel/pages/login-page-model.js on lines 116..119
    sites/src/js/viewmodel/settings/mail-address-setting-model.js on lines 58..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      validatePassword(password) {
    return ValidationUtils.validate(Validators.loginPassword, password,
      {field: "パスワード"}, (error) => this.error = error );
  }
    Severity: Major
    Found in sites/src/js/viewmodel/pages/login-page-model.js and 3 other locations - About 30 mins to fix
    sites/src/js/viewmodel/agents/agent-source-editor.js on lines 83..86
    sites/src/js/viewmodel/pages/login-page-model.js on lines 120..123
    sites/src/js/viewmodel/settings/mail-address-setting-model.js on lines 58..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
    Open

    import ContainerJS         from "container-js"
    Severity: Minor
    Found in sites/src/js/viewmodel/pages/login-page-model.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status