Sign upLogin

unageanu/jiji2

View on GitHub
Star
sites/src/js/viewmodel/settings/smtp-server-setting-model.js

Summary

Maintainability
C
1 day
Test Coverage

SMTPServerSettingModel has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class SMTPServerSettingModel extends Observable {

  constructor(smtpServerSettingService, timeSource) {
    super();
    this.smtpServerSettingService  = smtpServerSettingService;
Severity: Minor
Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          (result) => {
        this.isSaving = false
        this.setting = setting;
        this.message = "設定を変更しました。 ("
          + DateFormatter.format(this.timeSource.now) + ")";
    Severity: Major
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js and 1 other location - About 1 hr to fix
    sites/src/js/viewmodel/settings/mail-address-setting-model.js on lines 45..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          (error) => {
        this.isSaving = false
        this.error = ErrorMessages.getMessageFor(error);
        error.preventDefault = true;
        throw error;
    Severity: Minor
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js and 1 other location - About 50 mins to fix
    sites/src/js/viewmodel/pages/initial-settings-page-model.js on lines 87..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      validateHost(host) {
    return ValidationUtils.validate(Validators.smtpServer.host, host,
        {field: "SMTPサーバー"}, (error) => this.hostError = error );
  }
    Severity: Major
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js and 3 other locations - About 40 mins to fix
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 101..104
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 105..108
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 109..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      validateUserName(userName) {
    return ValidationUtils.validate(Validators.smtpServer.userName, userName,
        {field: "ユーザー名"}, (error) => this.userNameError = error );
  }
    Severity: Major
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js and 3 other locations - About 40 mins to fix
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 97..100
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 101..104
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 109..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      validatePort(port) {
    return ValidationUtils.validate(Validators.smtpServer.port, port,
        {field: "SMTPポート"}, (error) => this.portError = error );
  }
    Severity: Major
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js and 3 other locations - About 40 mins to fix
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 97..100
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 105..108
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 109..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      validatePassword(password) {
    return ValidationUtils.validate(Validators.smtpServer.password, password,
        {field: "パスワード"}, (error) => this.passwordError = error );
  }
    Severity: Major
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js and 3 other locations - About 40 mins to fix
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 97..100
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 101..104
    sites/src/js/viewmodel/settings/smtp-server-setting-model.js on lines 105..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
    Open

    import Observable      from "../../utils/observable"
    Severity: Minor
    Found in sites/src/js/viewmodel/settings/smtp-server-setting-model.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status