Showing 253 of 368 total issues
Method taxon_concepts_csv_columns has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def taxon_concepts_csv_columns
[
:id,
:kingdom_name, :phylum_name, :class_name, :order_name, :family_name,
:genus_name, :species_name, :subspecies_name,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update
update_result =
if user_params[:password].blank?
@user.update_without_password(user_params)
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method search_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def search_params
(params[:filters] || params).permit(
:time_range_start,
:time_range_end,
:report_type,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method countries_ids has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def countries_ids
if respond_to?(:countries_ids_ary) && countries_ids_ary?
countries_ids_ary || []
elsif respond_to? :tc_countries_ids_ary
tc_countries_ids_ary || []- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def index
return render :json => [] if params[:taxon_concept_ids].nil?
return render :json => [] unless params[:taxon_concept_ids].kind_of?(Array)
res = params[:taxon_concept_ids].map do |tc_id|
tc = MTaxonConcept.find_by_id(tc_id)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method copy_distribution_taggings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def copy_distribution_taggings(reassignable, copied_object)
if reassignable.taggings.count == 0
copied_object.taggings.destroy_all if copied_object.taggings.count > 0
return
elsif copied_object.id && copied_object.taggings.count == 0- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method slice_values has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def slice_values(trade_code, code_type)
return ("NULL," * 3).chop unless trade_code
# When code value is 'NULL' it means that this is
# an actual condition to be met for the mapping.
# This is why the id is -1 instead of NULL.- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method perform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def perform(aru_id, submitter_id)
submitter = User.find(submitter_id)
begin
aru = Trade::AnnualReportUpload.find(aru_id)
rescue ActiveRecord::RecordNotFound => e- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method perform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def perform(options)
sql = <<-SQL
SELECT * FROM copy_quotas_across_years(
:from_year,
:start_date,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method perform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def perform(aru_id, user_id)
begin
aru = Trade::AnnualReportUpload.find(aru_id)
rescue ActiveRecord::RecordNotFound => e
# catch this exception so that retry is not scheduled- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method format_taxa_fields has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def format_taxa_fields(taxa_fields)
return 'NULL' unless taxa_fields.present?
taxa_fields.keys.map do |key|
next unless taxa_fields[key].is_a?(Array)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method taxonomic_download has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.taxonomic_download(params)
mapping = Trade::Grouping::Compliance.new('').read_taxonomy_conversion
array_ids = []
mapping[params[:ids]].each do |m|
rank_name = m[:rank] == 'Species' ? 'taxon' : m[:rank].downcase- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sanitise_symbol has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def sanitise_symbol(s, default = nil)
return nil unless s
s.is_a?(Symbol) && s || s.is_a?(String) && s.strip.downcase.to_sym || default
end- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"