Sign upLogin

universoimpulso/atena

View on GitHub
Star
src/controllers/CommandController/utils.js

Summary

Maintainability
D
2 days
Test Coverage

Function givePoints has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async givePoints({ user, usernames, provider, points, reason }) {
    const response = {
      msg: 'Eis o resultado do seu comando: ',
      attachments: []
    }
Severity: Major
Found in src/controllers/CommandController/utils.js - About 2 hrs to fix

    File utils.js has 252 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import moment from 'moment'

import { scoreTypes } from '../../models/Score/schema'
import User from '../../models/User'
import BotController from '../BotController'
    Severity: Minor
    Found in src/controllers/CommandController/utils.js - About 2 hrs to fix

      Function generateUserScoresMessage has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async generateUserScoresMessage(user) {
    const response = { msg: '', attachments: [] }

    if (user.isCoreTeam) {
      const { score } = await RankingController.getMonthlyPositionByUser(
      Severity: Minor
      Found in src/controllers/CommandController/utils.js - About 1 hr to fix

        Function getCommandsText has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          getCommandsText({ isCoreTeam }) {
    const message = {
      msg: '*Confira a nossa lista de comandos:*',
      attachments: [
        {
        Severity: Minor
        Found in src/controllers/CommandController/utils.js - About 1 hr to fix

          Function generateRankingMessage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            generateRankingMessage({ ranking, user, userRanking, monthName }) {
    if (!ranking || ranking.length < 5)
      return 'Ops. Ainda não temos dados suficientes para gerar o ranking neste momento. :/'

    const type = monthName ? `de ${monthName}` : 'geral'
          Severity: Minor
          Found in src/controllers/CommandController/utils.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function generateRankingMessage has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            generateRankingMessage({ ranking, user, userRanking, monthName }) {
    if (!ranking || ranking.length < 5)
      return 'Ops. Ainda não temos dados suficientes para gerar o ranking neste momento. :/'

    const type = monthName ? `de ${monthName}` : 'geral'
          Severity: Minor
          Found in src/controllers/CommandController/utils.js - About 1 hr to fix

            Function givePoints has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              async givePoints({ user, usernames, provider, points, reason }) {
    const response = {
      msg: 'Eis o resultado do seu comando: ',
      attachments: []
    }
            Severity: Minor
            Found in src/controllers/CommandController/utils.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (monthly.score) {
      response.attachments.push({
        text: `${monthly.score} pontos de reputação no ranking mensal!
        Você está na posição ${monthly.position} :grin: `
      })
            Severity: Major
            Found in src/controllers/CommandController/utils.js and 1 other location - About 2 hrs to fix
            src/controllers/CommandController/utils.js on lines 166..175

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (general.score) {
      response.attachments.push({
        text: `${general.score} pontos de reputação no ranking geral!
        Você está na posição ${general.position} :partying_face:`
      })
            Severity: Major
            Found in src/controllers/CommandController/utils.js and 1 other location - About 2 hrs to fix
            src/controllers/CommandController/utils.js on lines 155..164

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 83.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                response.msg = `Olá ${
      user.name.split(' ')[0]
    }! Atualmente você está no nível ${user.level.value}.
    Segue a sua pontuação em nossos rankings:`
            Severity: Minor
            Found in src/controllers/CommandController/utils.js and 1 other location - About 40 mins to fix
            src/controllers/CommandController/utils.js on lines 130..134

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  response.msg = `Olá ${
        user.name.split(' ')[0]
      }! Atualmente você está no nível ${user.level.value}.
        Como você faz parte do coreTeam, não tem posição no ranking geral ou mensal. 😕
        Segue a sua pontuação até o momento:`
            Severity: Minor
            Found in src/controllers/CommandController/utils.js and 1 other location - About 40 mins to fix
            src/controllers/CommandController/utils.js on lines 150..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status