Sign upLogin

universoimpulso/atena

View on GitHub
Star
src/controllers/ScoreController/index.js

Summary

Maintainability
D
3 days
Test Coverage

File index.js has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { sendError } from 'log-on-slack'
import moment from 'moment'

import { achievementTypes, messageProviders } from '../../config/achievements'
import { scoreRules } from '../../config/score'
Severity: Minor
Found in src/controllers/ScoreController/index.js - About 5 hrs to fix

    Function removeScoreFromReaction has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async removeScoreFromReaction({ reaction, payload }) {
    try {
      const { deletedCount } = await Score.deleteMany({
        description: scoreTypes.reactionSended,
        'details.messageId': reaction.provider.messageId,
    Severity: Major
    Found in src/controllers/ScoreController/index.js - About 2 hrs to fix

      Function handleProfileCompleteness has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async handleProfileCompleteness(payload) {
    try {
      const { uuid, completeness, provider } = payload

      let user = await User.findOne({ uuid })
      Severity: Major
      Found in src/controllers/ScoreController/index.js - About 2 hrs to fix

        Function handleExternalInteraction has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async handleExternalInteraction(payload) {
    try {
      const { scoreType, achievementType, queries, details } = payload

      const user = await User.findOne(queries.user)
        Severity: Minor
        Found in src/controllers/ScoreController/index.js - About 1 hr to fix

          Function scoreReactionReceived has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async scoreReactionReceived({
    receiver,
    reaction,
    payload,
    alreadyAchieved
          Severity: Minor
          Found in src/controllers/ScoreController/index.js - About 1 hr to fix

            Function scoreReactionRemoved has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              async scoreReactionRemoved({ sender, receiver, reaction }) {
    try {
      const options = {
        runValidators: true,
        upsert: true,
            Severity: Minor
            Found in src/controllers/ScoreController/index.js - About 1 hr to fix

              Function handleProfileCompleteness has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                async handleProfileCompleteness(payload) {
    try {
      const { uuid, completeness, provider } = payload

      let user = await User.findOne({ uuid })
              Severity: Minor
              Found in src/controllers/ScoreController/index.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function scoreReactionSended has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                async scoreReactionSended({ sender, reaction, payload, alreadyAchieved }) {
    try {
      if (await this.reactionSendedCannotScore({ reaction, payload })) return
      await Score.create({
        user: sender.uuid,
              Severity: Minor
              Found in src/controllers/ScoreController/index.js - About 1 hr to fix

                Function handleMessage has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Wontfix

                  async handleMessage({ payload, message, user }) {
    try {
      if (await this.messageCannotScore({ payload, message, user })) return user

      const description = message.provider.parentId
                Severity: Minor
                Found in src/controllers/ScoreController/index.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    async handleMeetupParticipation({ user, meetup }) {
    const scoreEarned = scoreRules.meetup.participation

    await Score.create({
      user: user.uuid,
                  Severity: Major
                  Found in src/controllers/ScoreController/index.js and 1 other location - About 3 hrs to fix
                  src/controllers/ScoreController/index.js on lines 185..198

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 105.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    async handleMeetupSubscription({ user, meetup }) {
    const scoreEarned = scoreRules.meetup.subscription

    await Score.create({
      user: user.uuid,
                  Severity: Major
                  Found in src/controllers/ScoreController/index.js and 1 other location - About 3 hrs to fix
                  src/controllers/ScoreController/index.js on lines 200..213

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 105.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        const { deletedCount } = await Score.deleteMany({
        description: scoreTypes.reactionSended,
        'details.messageId': reaction.provider.messageId,
        'details.content': reaction.content,
        user: reaction.user
                  Severity: Minor
                  Found in src/controllers/ScoreController/index.js and 1 other location - About 55 mins to fix
                  src/controllers/ScoreController/utils.js on lines 39..44

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Wontfix

                      try {
      await Score.create({
        user: user.uuid,
        score: scoreEarned,
        description: scoreTypes.newAchievement,
                  Severity: Major
                  Found in src/controllers/ScoreController/index.js and 2 other locations - About 50 mins to fix
                  src/controllers/ScoreController/index.js on lines 78..109
                  src/controllers/ScoreController/index.js on lines 118..158

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Wontfix

                      try {
      if (await this.reactionSendedCannotScore({ reaction, payload })) return
      await Score.create({
        user: sender.uuid,
        score: scoreRules.reaction.send,
                  Severity: Major
                  Found in src/controllers/ScoreController/index.js and 2 other locations - About 50 mins to fix
                  src/controllers/ScoreController/index.js on lines 118..158
                  src/controllers/ScoreController/index.js on lines 162..182

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Wontfix

                      try {
      if (
        await this.reactionReceivedCannotScore({ receiver, reaction, payload })
      )
        return
                  Severity: Major
                  Found in src/controllers/ScoreController/index.js and 2 other locations - About 50 mins to fix
                  src/controllers/ScoreController/index.js on lines 78..109
                  src/controllers/ScoreController/index.js on lines 162..182

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status