Sign upLogin

unrealwork/atsd-api-nodejs

View on GitHub
Star
src/lib/series.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function queryStatistic has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

Series.prototype.queryStatistic = function (metric, entity, tags, startTime, endTime, statistic, period, callback) {
Severity: Major
Found in src/lib/series.js - About 1 hr to fix

    Function queryDetail has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    Series.prototype.queryDetail = function (metric, entity, tags, startTime, endTime, callback) {
    Severity: Minor
    Found in src/lib/series.js - About 45 mins to fix

      Function insertData has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      Series.prototype.insertData = function (metric, entity, tags, data, callback) {
      Severity: Minor
      Found in src/lib/series.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        Series.prototype.query = function (payload, callback) {
    var path = 'series/query';
    this.postRequest(path, {}, payload, function (error, response, body) {
        callback(error, response, body);
    });
        Severity: Major
        Found in src/lib/series.js and 1 other location - About 1 hr to fix
        src/lib/series.js on lines 144..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        Series.prototype.insert = function (payload, callback) {
    var path = 'series/insert';

    this.postRequest(path, {}, payload, function (error, response, body) {
        callback(error, response, body);
        Severity: Major
        Found in src/lib/series.js and 1 other location - About 1 hr to fix
        src/lib/series.js on lines 50..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status