Sign upLogin

ursinn/BukkitMaintenance

View on GitHub
Star

Showing 5 of 15 total issues

Method a has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void a(Packet0Handshake packet, DataInputStream reader, DataOutputStream writer) throws Exception {
        if (packet.getD() == 2) {
            DisconnectJSON json = new DisconnectJSON();
            json.setText(Config.getKickMessage());
Severity: Minor
Found in src/main/java/de/howaner/bukkitmaintenance/util/PacketListener.java - About 1 hr to fix

Method run has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void run() {
        try {
            try (ServerSocket server = new ServerSocket(Config.getBindPort(), 50, InetAddress.getByName(Config.getBindAddress()))) {
                Socket socket;
Severity: Minor
Found in src/main/java/de/howaner/bukkitmaintenance/util/PacketListener.java - About 1 hr to fix

Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public void run() {
        try {
            try (ServerSocket server = new ServerSocket(Config.getBindPort(), 50, InetAddress.getByName(Config.getBindAddress()))) {
                Socket socket;
Severity: Minor
Found in src/main/java/de/howaner/bukkitmaintenance/util/PacketListener.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createPingString has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static String createPingString(int protocolVersion, String version, String motd, int players, int slots) {
Severity: Minor
Found in src/main/java/de/howaner/bukkitmaintenance/util/PingUtil.java - About 35 mins to fix

Method a has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void a(Packet0Handshake packet, DataInputStream reader, DataOutputStream writer) throws Exception {
        if (packet.getD() == 2) {
            DisconnectJSON json = new DisconnectJSON();
            json.setText(Config.getKickMessage());
Severity: Minor
Found in src/main/java/de/howaner/bukkitmaintenance/util/PacketListener.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language