Sign upLogin

uu-cubitt/commands

View on GitHub
Star

Showing 4 of 37 total issues

File CommandFactory.ts has 361 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as Common from "cubitt-common";

import {CommandType} from "./CommandType";
import {Command} from "./commands/Command";
import {AddConnectorCommand} from "./commands/AddConnectorCommand";
Severity: Minor
Found in src/CommandFactory.ts - About 4 hrs to fix

    Function parse has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static parse(jsonObject: Object): Command {
        if (typeof(jsonObject) === "undefined" || jsonObject === null) {
            throw new Error("COMMAND ERROR: Empty object cannot be parsed.");
        }
        let typeString: string = jsonObject["type"];
    Severity: Minor
    Found in src/CommandFactory.ts - About 1 hr to fix

      Function getCommandType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected static getCommandType(type: string): CommandType {
        switch (type) {
            case "AddConnectorCommand":
                return CommandType.AddConnector;
            case "AddEdgeCommand":
      Severity: Minor
      Found in src/CommandFactory.ts - About 1 hr to fix

        Function validateObject has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            protected static validateObject(object: Object, keysWithType: Common.Dictionary<ValidationType>): void {
        for (let key in keysWithType) {
            let type: ValidationType = keysWithType[key];
            let val: any = object[key];
            if (typeof(val) === "undefined") {
        Severity: Minor
        Found in src/CommandFactory.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language