Sign upLogin

vampireneo/Book

View on GitHub
Star
bookParser/Books.js

Summary

Maintainability
C
1 day
Test Coverage

Function getByISBN has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.getByISBN = function(pISBN) {
  var domain = 'http://search.books.com.tw';
  var searchUrl = '/exep/prod_search.php?cat=BKA&key=';
  var bookObj = {};
  var deferred = Q.defer();
Severity: Major
Found in bookParser/Books.js - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                  if (text.length !== 2) {
                continue;
              }
    Severity: Major
    Found in bookParser/Books.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                    if (text2.length !== 2) {
                continue;
              }
      Severity: Major
      Found in bookParser/Books.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                      switch (title2) {
                case 'ISBN':
                  bookObj.ISBN = content2;
                  break;
                case '叢書系列':
        Severity: Major
        Found in bookParser/Books.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        switch (title) {
                //原文作者
                //譯者
                case '出版社':
                  bookObj.Publisher = content;
          Severity: Major
          Found in bookParser/Books.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          var title = text[0].replace(/\s/g, '').trim(),
                content = text[1]
                .trim()
                .replace(/\s+/g, ' ')
                .trim()
            Severity: Major
            Found in bookParser/Books.js and 1 other location - About 1 hr to fix
            bookParser/Books.js on lines 80..85

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          var title2 = text2[0].replace(/\s/g, '').trim(),
                content2 = text2[1]
                .trim()
                .replace(/\s+/g, ' ')
                .trim()
            Severity: Major
            Found in bookParser/Books.js and 1 other location - About 1 hr to fix
            bookParser/Books.js on lines 50..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 68.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status