Sign upLogin

viagogo/gogokit.php

View on GitHub
Star

Showing 5 of 12 total issues

Function getChangedResources has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function getChangedResources($nextLink, ViagogoRequestParams $params = null, $type) {
        $params = $params ?: new ViagogoRequestParams();
        $params->page = 1;
        $params->page_size = 10000;
Severity: Minor
Found in src/hal/HalClient.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getChangedResources has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getChangedResources($nextLink, ViagogoRequestParams $params = null, $type) {
        $params = $params ?: new ViagogoRequestParams();
        $params->page = 1;
        $params->page_size = 10000;
Severity: Minor
Found in src/hal/HalClient.php - About 1 hr to fix

    Function getAllResources has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getAllResources($url, ViagogoRequestParams $params = null, $type) {
        $params = $params ?: new ViagogoRequestParams();        
        $params->page = 1;
        $params->page_size = 1000;
    Severity: Minor
    Found in src/hal/HalClient.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method postFile has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        function postFile($urlRoute, $fileContent, $fileName, ViagogoRequestParams $params = null, $type) {
    Severity: Minor
    Found in src/clients/Client.php - About 35 mins to fix

      Function handleError has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function handleError($clientException) {
        $codeStatus = $clientException->getCode();

        if ($codeStatus == 404) {
            return new \Viagogo\Exceptions\ResourceNotFoundException($codeStatus, $clientException->getMessage(), 1, $clientException);
      Severity: Minor
      Found in src/core/ErrorHandler.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language