Showing 9 of 9 total issues
Class RestModel has 25 methods (exceeds 20 allowed). Consider refactoring. Open
class RestModel
extend ActiveModel::Naming
extend ActiveModel::Translation
include Virtus.model(:nullify_blank => true)Method parse_json has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def self.parse_json(json, opts = {})
begin
json_response = JSON.parse json
data_type = opts[:type]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method get_response_callback has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def self.get_response_callback(args)
lambda do |response, request, result, &block|
if response.code >= 200 && response.code < 300
RestApiClient.parse_json response, args
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build_instance has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.build_instance(data_type, instance_data)
instance = data_type.new
instance_data.each do |key, value|
begin- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method do_request_without_payload has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.do_request_without_payload(method, service_key, path, args = {:params => {}}, headers = {})Method do_request_with_payload has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.do_request_with_payload(method, service_key, path, args = {:params => {}}, headers = {})Avoid too many return statements within this method. Open
return json_dataAvoid too many return statements within this method. Open
return (opts[:default_return] || nil)Avoid too many return statements within this method. Open
return json_response