Sign upLogin

vinsol/spree-point-of-sale

View on GitHub
Star

Showing 2 of 2 total issues

Class PosController has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

class Spree::Admin::PosController < Spree::Admin::BaseController
  before_action :load_order, :ensure_pos_order, :ensure_unpaid_order, except: :new
  helper_method :user_stock_locations
  before_action :load_variant, only: [:add, :remove]
  before_action :ensure_active_store
Severity: Minor
Found in app/controllers/spree/admin/pos_controller.rb - About 3 hrs to fix

    Method activate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.activate

      Dir.glob(File.join(File.dirname(__FILE__), '../../app/**/*_decorator*.rb')) do |c|
        Rails.configuration.cache_classes ? require(c) : load(c)
      end
    Severity: Minor
    Found in lib/spree_pos/engine.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language