Sign upLogin

vinsol/spree_admin_roles_and_access

View on GitHub
Star

Showing 3 of 3 total issues

Function SearchableList has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var SearchableList = (function() {
  var SearchableCheckboxList = function(container) {
    this.$searchBox = $("<div class='input-group input-group-lg col-xs-12'>\
                           <input type='text' placeholder='Search..' class='narrow-down-list form-control'></input>\
                            <div class='input-group-btn search-icon-btn'>\
Severity: Major
Found in app/assets/javascripts/spree/backend/spree_admin_roles_and_access.js - About 2 hrs to fix

    Method authorize_admin has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def authorize_admin
    begin
      if params[:id]
        record = model_class.where(PARAM_ATTRIBUTE[controller_name] => params[:id]).first
      elsif new_action?
    Severity: Minor
    Found in app/controllers/spree/admin/base_controller_decorator.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def method_missing(name, *args, &block)
      if name.to_s.starts_with?('can')
        can, action, subject, attribute = find_action_and_subject(name)

        Permissions.send(:define_method, name) do |current_ability, user|
    Severity: Minor
    Found in lib/spree/permissions.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language