visavi/rotor

View on GitHub

Showing 286 of 512 total issues

Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function create(string $login, Request $request, Validator $validator, Flood $flood): RedirectResponse
    {
        if (! getUser()) {
            abort(403, __('main.not_authorized'));
        }
Severity: Minor
Found in app/Http/Controllers/WallController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rating has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function rating(Request $request): JsonResponse
    {
        $types = [
            Post::$morphName,
            Article::$morphName,
Severity: Minor
Found in app/Http/Controllers/AjaxController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function zipView has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function zipView(int $id, int $fid): View
    {
        /** @var File $file */
        $file = File::query()->where('relate_type', Down::$morphName)->find($id);
        $down = $file?->relate;
Severity: Minor
Found in app/Http/Controllers/Load/DownController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function handle(Request $request, Closure $next)
    {
        if (Route::has('install') && $request->is('install*')) {
            return $next($request);
        }
Severity: Minor
Found in app/Http/Middleware/AuthenticateCookie.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function edit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function edit(int $id, Request $request, Validator $validator)
    {
        if (! $user = getUser()) {
            abort(403, __('main.not_authorized'));
        }
Severity: Minor
Found in app/Http/Controllers/BoardController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function uploadFile has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function uploadFile(UploadedFile $file, bool $record = true): array
    {
        $mime = $file->getClientMimeType();
        $extension = strtolower($file->getClientOriginalExtension());
        $basename = getBodyName($file->getClientOriginalName());
Severity: Minor
Found in app/Traits/UploadTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ban has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function ban(Request $request, Validator $validator)
    {
        if (! $user = getUser()) {
            abort(403, __('main.not_authorized'));
        }
Severity: Minor
Found in app/Http/Controllers/User/BanController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function key has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function key(Request $request, Validator $validator)
    {
        /* @var User $user */
        if (! $user = getUser()) {
            abort(403, __('main.not_authorized'));
Severity: Minor
Found in app/Http/Controllers/User/UserController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function create(Request $request, Validator $validator)
    {
        if ($this->user->point < setting('rekuserpoint')) {
            abort(200, __('adverts.advert_point', ['point' => plural(50, setting('scorename'))]));
        }
Severity: Minor
Found in app/Http/Controllers/AdvertController.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method edit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function edit(int $id, Request $request, Validator $validator)
    {
        $page = int($request->input('page', 1));
        $photo = Photo::query()->find($id);

Severity: Minor
Found in app/Http/Controllers/Admin/PhotoController.php - About 1 hr to fix

    Method editArticle has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function editArticle(int $id, Request $request, Validator $validator)
        {
            /** @var Article $article */
            $article = Article::query()->find($id);
    
    
    Severity: Minor
    Found in app/Http/Controllers/Admin/ArticleController.php - About 1 hr to fix

      Method edit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function edit(int $id, Request $request, Validator $validator)
          {
              if (! $user = getUser()) {
                  abort(403);
              }
      Severity: Minor
      Found in app/Http/Controllers/GuestbookController.php - About 1 hr to fix

        Method delete has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function delete(Request $request, Validator $validator): RedirectResponse
            {
                if (! is_writable(resource_path('views/' . $this->path))) {
                    abort(200, __('admin.files.directory_not_writable', ['dir' => $this->path]));
                }
        Severity: Minor
        Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix

          Method publish has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function publish(int $id, Request $request): RedirectResponse
              {
                  /** @var Down $down */
                  $down = Down::query()->find($id);
          
          
          Severity: Minor
          Found in app/Http/Controllers/Admin/LoadController.php - About 1 hr to fix

            Method checkLogin has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function checkLogin(Request $request, Validator $validator): JsonResponse
                {
                    $login = (string) $request->input('login');
            
                    $validator
            Severity: Minor
            Found in app/Http/Controllers/User/UserController.php - About 1 hr to fix

              Method deleteTopic has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function deleteTopic(int $id, Request $request, Validator $validator): RedirectResponse
                  {
                      $page = int($request->input('page', 1));
              
                      /** @var Topic $topic */
              Severity: Minor
              Found in app/Http/Controllers/Admin/ForumController.php - About 1 hr to fix

                Method send has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function send(Request $request, Validator $validator): RedirectResponse
                    {
                        $userkeys = int($request->input('userkeys'));
                
                        /* @var User $user */
                Severity: Minor
                Found in app/Http/Controllers/Admin/InvitationController.php - About 1 hr to fix

                  Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function handle(Request $request, Closure $next)
                      {
                          if ($this->isBanned($request)) {
                              return redirect('ipban');
                          }
                  Severity: Minor
                  Found in app/Http/Middleware/CheckAccessSite.php - About 1 hr to fix

                    Method edit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function edit(int $id, Request $request, Validator $validator)
                        {
                            /** @var Notice $notice */
                            $notice = Notice::query()->find($id);
                    
                    
                    Severity: Minor
                    Found in app/Http/Controllers/Admin/NoticeController.php - About 1 hr to fix

                      Method edit has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function edit(Request $request, Validator $validator)
                          {
                              $path = $this->path;
                              $file = $path ? '/' . $this->file : $this->file;
                              $writable = is_writable(resource_path('views/' . $path . $file . '.blade.php'));
                      Severity: Minor
                      Found in app/Http/Controllers/Admin/FileController.php - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language