volontariat/voluntary

View on GitHub
app/assets/javascripts/voluntary/lib/jquery.multisortable.js

Summary

Maintainability
D
2 days
Test Coverage

Function multisortable has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  $.fn.multisortable = function(options) {
    if (!options) {
      options = {}
    }
    var settings = $.extend({}, $.fn.multisortable.defaults, options);
Severity: Major
Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js - About 3 hrs to fix

    Function multiselectable has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      $.fn.multiselectable = function(options) {
        if (!options) {
          options = {}
        }
        options = $.extend({}, $.fn.multiselectable.defaults, options);
    Severity: Major
    Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js - About 3 hrs to fix

      Function mouseDown has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function mouseDown(e) {
            var item = $(this),
              parent = item.parent(),
              myIndex = item.index();
      
      
      Severity: Minor
      Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js - About 1 hr to fix

        Function sort has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              options.sort = function(event, ui) {
                var parent = ui.item.parent(),
                  myIndex = ui.item.data('i'),
                  top = parseInt(ui.item.css('top').replace('px', '')),
                  left = parseInt(ui.item.css('left').replace('px', ''));
        Severity: Minor
        Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js - About 1 hr to fix

          Function regroup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function regroup(item, list) {
                if (list.find('.' + settings.selectedClass).length > 0) {
                  var myIndex = item.data('i');
          
                  var itemsBefore = list.find('.' + settings.selectedClass).filter(function() {
          Severity: Minor
          Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var itemsAfter = list.find('.' + settings.selectedClass).filter(function() {
                      return $(this).data('i') > myIndex
                    }).css({
                        position: '',
                        width: '',
            Severity: Major
            Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/voluntary/lib/jquery.multisortable.js on lines 125..133

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    var itemsBefore = list.find('.' + settings.selectedClass).filter(function() {
                      return $(this).data('i') < myIndex
                    }).css({
                        position: '',
                        width: '',
            Severity: Major
            Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/voluntary/lib/jquery.multisortable.js on lines 137..145

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $('.' + settings.selectedClass, parent).filter(function() {
                      return $(this).data('i') > myIndex;
                    }).each(function() {
                        var item = $(this);
                        item.css({
            Severity: Minor
            Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js and 1 other location - About 50 mins to fix
            app/assets/javascripts/voluntary/lib/jquery.multisortable.js on lines 201..203

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $('.' + settings.selectedClass, parent).filter(function() {
                      return $(this).data('i') < myIndex;
                    }).reverse().each(function() {
            Severity: Minor
            Found in app/assets/javascripts/voluntary/lib/jquery.multisortable.js and 1 other location - About 50 mins to fix
            app/assets/javascripts/voluntary/lib/jquery.multisortable.js on lines 215..228

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status