volontariat/voluntary

View on GitHub

Showing 146 of 242 total issues

Method down has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def down
    add_column :vacancies, :user_id, :integer
    
    if (Product::Recruiting rescue nil)
      Vacancy.where('resource_type = "User"').update_all('user_id = resource_id')

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method keyword_settings_present has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

          def keyword_settings_present
            return unless self.with_keywords.present?
            
            [:min_number_of_keywords, :max_number_of_keywords].each do |attribute|
              if self.send(attribute).blank?
Severity: Minor
Found in lib/model/mongo_db/product/keywords.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_i18n_locale_from_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

          def set_i18n_locale_from_params
            if params[:locale]
              if I18n.available_locales.include?(params[:locale].to_sym)
                I18n.locale = params[:locale]
              else
Severity: Minor
Found in lib/applicat/mvc/controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method thing= has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def thing=(thing)
          thing.save if thing.new_record?
          
          self.thing_type = thing.class.name; self.thing_id = thing.id
          
Severity: Minor
Found in lib/concerns/model/base_list_item.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method up has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def up
    Product.each do |product|
      next if product.klass_name.present?
      
      if product.name == 'Product'

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def update
          resource = current_user.arguments.where('arguments.id = ?', params[:id]).first
          errors = {}
          
          if resource.nil?
Severity: Minor
Found in app/controllers/voluntary/api/v1/arguments_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language