Sign upLogin

voltrb/volt

View on GitHub
Star

Showing 316 of 336 total issues

Method initialize has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(volt_app, target, context, binding_name, getter, variable_name, index_name, template_name)
Severity: Major
Found in lib/volt/page/bindings/each_binding.rb - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

                if ( tokens.length > 2 && (token = tokens[0]).type === "ID" &&
                    support.getById && context.nodeType === 9 && documentIsHTML &&
                    Expr.relative[ tokens[1].type ] ) {

                context = ( Expr.find["ID"]( token.matches[0].replace(runescape, funescape), context ) || [] )[0];
    Severity: Major
    Found in app/volt/assets/js/jquery-2.0.3.js - About 1 hr to fix

      Method value= has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def value=(val)
      case @attribute_name
        when 'value'
          if @is_option
            # When a new option is added, we trigger the invalidate event on the
      Severity: Minor
      Found in lib/volt/page/bindings/attribute_binding.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method login has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def login(login_info)
    login = login_info['login']
    password = login_info['password']

    query = { User.login_field => login }
      Severity: Minor
      Found in app/volt/tasks/user_tasks.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method rezero_bindings has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def rezero_bindings(html, bindings)
      @@base_binding_id ||= 20_000
      # rezero
      parts  = html.split(/(\<\!\-\- \$\/?[0-9]+ \-\-\>)/).reject { |v| v == '' }
      Severity: Minor
      Found in lib/volt/page/targets/attribute_section.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method component has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def component(name)
      unless @included_components[name]
        # Track that we added
        @included_components[name] = true
      Severity: Minor
      Found in lib/volt/server/rack/asset_files.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method own_by_user has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def own_by_user(key = :user_id)
          relation, pattern = key.to_s, /_id$/
          if relation.match(pattern)
            belongs_to key.to_s.gsub(pattern, '')
          else
      Severity: Minor
      Found in lib/volt/models/permissions.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method closed has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def closed
      unless @closed
        @closed = true
        # Remove ourself from the available channels
        @@channels.delete(self)
      Severity: Minor
      Found in lib/volt/server/socket_connection_handler.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method find_by_tag_id has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def find_by_tag_id(tag_id)
      @nodes.each do |node|
        if node.is_a?(ComponentNode)
          # Walk down nodes
          val = node.find_by_tag_id(tag_id)
      Severity: Minor
      Found in lib/volt/page/targets/binding_document/component_node.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.validate(model, field_name, args)
      errors = {}
      value  = model.get(field_name)

      if args.is_a?(Array)
      Severity: Minor
      Found in lib/volt/models/validators/inclusion_validator.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method filter_args has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def filter_args(args)
    if args.is_a?(Array)
      args.map { |v| filter_args(v) }
    elsif args.is_a?(Hash)
      args.map do |k, v|
      Severity: Minor
      Found in lib/volt/utils/logging/task_argument_filterer.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method inspect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def inspect
    result = "#<#{self.class}(#{object_id})"

    if @next
      result += " >> #{@next.inspect}"
      Severity: Minor
      Found in lib/volt/utils/promise_extensions.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method add_listener has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def add_listener
      @listening = true

      # Call the backend and add the listner
      QueryTasks.add_listener(@collection, @query).then do |ret|
      Severity: Minor
      Found in lib/volt/models/persistors/query/query_listener.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method remove has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def remove(*args)
      stack   = []
      section = @pool

      args.each_with_index do |arg, index|
      Severity: Minor
      Found in lib/volt/utils/generic_pool.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process_attribute has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def process_attribute(tag_name, attributes, attribute_name, value)
      parts, binding_count = binding_parts_and_count(value)

      # if this attribute has bindings
      if binding_count > 0
      Severity: Minor
      Found in lib/volt/server/html_parser/attribute_scope.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cweek_cyear has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def cweek_cyear
    jan01 = Time.new(self.year, 1, 1)
    jan01_wday = jan01.wday
    first_monday = 0
    year = self.year
      Severity: Minor
      Found in lib/volt/utils/time_opal_patch.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(volt_app, target, context, binding_name, attribute_name, getter, setter)
      Severity: Major
      Found in lib/volt/page/bindings/attribute_binding.rb - About 50 mins to fix

        Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def initialize(volt_app, target, context, binding_name, binding_in_path, getter, content_template_path = nil)
        Severity: Major
        Found in lib/volt/page/bindings/view_binding.rb - About 50 mins to fix

          Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              access: function( elems, fn, key, value, chainable, emptyGet, raw ) {
          Severity: Major
          Found in app/volt/assets/js/jquery-2.0.3.js - About 50 mins to fix

            Method gm has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def self.gm(year, month = nil, day = nil, hour = nil, min = nil, sec = nil, millisecond = nil)
            Severity: Major
            Found in lib/volt/utils/time_opal_patch.rb - About 50 mins to fix
              Severity
              Category
              Status
              Source
              Language