Sign upLogin

vpoulailleau/pydxl

View on GitHub
Star

Showing 2 of 13 total issues

Function read has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def read(self):
        """Read a packet with the port handler."""
        # TODO check error code in packet.error
        data = []
        length_to_read = 6  # minimum packet size
Severity: Minor
Found in pydxl/protocol1.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function write_bytes has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def write_bytes(self, identifier, address, data, size):
Severity: Minor
Found in pydxl/protocol1.py - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language