Function binl_md5
has 82 lines of code (exceeds 25 allowed). Consider refactoring. Open
function binl_md5(x, len)
{
/* append padding */
x[len >> 5] |= 0x80 << ((len) % 32);
x[(((len + 64) >>> 9) << 4) + 14] = len;
File md5.js
has 276 lines of code (exceeds 250 allowed). Consider refactoring. Open
/* jshint ignore:start */
/*
* A JavaScript implementation of the RSA Data Security, Inc. MD5 Message
* Digest Algorithm, as defined in RFC 1321.
* Version 2.2 Copyright (C) Paul Johnston 1999 - 2009
Function rstr2any
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
function rstr2any(input, encoding)
{
var divisor = encoding.length;
var i, j, q, x, quotient;
Function str2rstr_utf8
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function str2rstr_utf8(input)
{
var output = "";
var i = -1;
var x, y;
Function md5_hh
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function md5_hh(a, b, c, d, x, s, t)
Function md5_ii
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function md5_ii(a, b, c, d, x, s, t)
Function md5_ff
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function md5_ff(a, b, c, d, x, s, t)
Function md5_gg
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function md5_gg(a, b, c, d, x, s, t)
Function md5_cmn
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
function md5_cmn(q, a, b, x, s, t)
Identical blocks of code found in 2 locations. Consider refactoring. Open
angular.module('md5', []).constant('md5', (function() {
/*
* Configurable variables. You may need to tweak these to be compatible with
* the server-side, but the defaults work in most cases.
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 4332.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76