waterlinejs/rabbitmq-adapter

View on GitHub

Showing 3 of 5 total issues

Function bindPersistenceHandler has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  bindPersistenceHandler () {
    let connectionId = this.model.getPersistenceConnection()
    let persistenceConnection = this.model.connections[connectionId]._adapter

    this.socket.on('data', (data) => {
Severity: Minor
Found in lib/handlers/persistence.js - About 1 hr to fix

    Function teardown has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      teardown (conn, cb) {
        if (_.isFunction(conn)) {
          cb = conn
          conn = null
        }
    Severity: Minor
    Found in lib/adapter.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      update (connection, collection, criteria, values, cb) {
    Severity: Minor
    Found in lib/adapter.js - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language