Sign upLogin

wbyoung/maguey

View on GitHub
Star
lib/adapters/sqlite3/procedures.js

Summary

Maintainability
C
1 day
Test Coverage

Function alterTable has 157 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  alterTable: function(data) {
    /* jscs:disable jsDoc */

    // we know the phrasing is capable of handling one index creation or index
    // drop. we need to create a procedure if there are more operations
Severity: Major
Found in lib/adapters/sqlite3/procedures.js - About 6 hrs to fix

    Function createTable has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            var createTable = function() {
          var dbcols = this.dbcols.filter(notDroppedColumn);
          var dbfks = this.dbfks.filter(notDroppedForeignKey);
          var phrasing = self._phrasing;
          var columnFragment = phrasing.columnFragment.bind(phrasing);
    Severity: Minor
    Found in lib/adapters/sqlite3/procedures.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            data.dropped.length +
      data.renamed.length +
      data.addedIndexes.length +
      data.droppedIndexes.length +
      data.renamedIndexes.length;
      Severity: Major
      Found in lib/adapters/sqlite3/procedures.js and 1 other location - About 1 hr to fix
      lib/dialect/phrasing_table.js on lines 72..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              promise = recreateTable ? promise : promise
          .return(data.renamedIndexes)
          .then(pluck('from'))
          .then(concat('droppedIndexes'));
      Severity: Minor
      Found in lib/adapters/sqlite3/procedures.js and 1 other location - About 40 mins to fix
      lib/adapters/sqlite3/procedures.js on lines 250..253

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              promise = recreateTable ? promise : promise
          .return(data.renamedIndexes)
          .then(pluck('from'))
          .then(concat('inspectIndexes'));
      Severity: Minor
      Found in lib/adapters/sqlite3/procedures.js and 1 other location - About 40 mins to fix
      lib/adapters/sqlite3/procedures.js on lines 277..280

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status