Sign upLogin

weacast/weacast-core

View on GitHub
Star
src/hooks/query.js

Summary

Maintainability
A
3 hrs
Test Coverage
A
90%

Function marshallSpatialQuery has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

export function marshallSpatialQuery (hook) {
  let query = hook.params.query
  if (query) {
    marshallGeometryQuery(query)
    // Resampling is used by hooks only, do not send it to DB
Severity: Major
Found in src/hooks/query.js - About 1 hr to fix

    Function processData has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
    Open

    export async function processData (hook) {
  let params = hook.params
  let query = params.query
  let service = hook.service
  let items = getItems(hook)
    Severity: Minor
    Found in src/hooks/query.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

        if (!_.isNil(params.oLon) && !_.isNil(params.oLat) && !_.isNil(params.sLon) && !_.isNil(params.sLat) && !_.isNil(params.dLon) && !_.isNil(params.dLat)) {
      items.forEach(item => {
        let grid = new Grid({
          bounds: service.forecast.bounds,
          origin: service.forecast.origin,
    Severity: Major
    Found in src/hooks/query.js - About 40 mins to fix

      Consider simplifying this complex logical expression.
      Open

          if (!_.isNil(query.oLon) && !_.isNil(query.oLat) && !_.isNil(query.sLon) && !_.isNil(query.sLat) && !_.isNil(query.dLon) && !_.isNil(query.dLat)) {
      // Convert when required from query strings
      hook.params.oLat = _.toNumber(query.oLat)
      hook.params.oLon = _.toNumber(query.oLon)
      hook.params.sLat = _.toNumber(query.sLat)
      Severity: Major
      Found in src/hooks/query.js - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status