Sign upLogin

weareswat/invoicexpress-gem

View on GitHub
Star

Showing 6 of 29 total issues

Function generateTOC has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function generateTOC() {
  if ($('#filecontents').length === 0) return;
  var _toc = $('<ol class="top"></ol>');
  var show = false;
  var toc = _toc;
Severity: Major
Found in doc/yard/js/app.js - About 2 hrs to fix

    Function searchItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    function searchItem() {
  for (var i = 0; i < searchCache.length / 50; i++) {
    var item = searchCache[searchIndex];
    var searchName = (searchString.indexOf('::') != -1 ? item.fullName : item.name);
    var matchString = regexSearchString;
    Severity: Minor
    Found in doc/yard/js/full_list.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fullListSearch has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function fullListSearch() {
  // generate cache
  searchCache = [];
  $('#full_list li').each(function() {
    var link = $(this).find('.object_link a');
    Severity: Minor
    Found in doc/yard/js/full_list.js - About 1 hr to fix

      Method request has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def request(method, path, options={})
      token = options.delete(:api_key)  || api_key
      url   = options.delete(:endpoint) || (api_endpoint % account_domain)
      klass = options.delete(:klass) || raise(ArgumentError, "Need a HappyMapper class to parse")
      Severity: Minor
      Found in lib/invoicexpress/request.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function summaryToggle has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function summaryToggle() {
  $('.summary_toggle').click(function() {
    if (localStorage) {
      localStorage.summaryCollapsed = $(this).text();
    }
      Severity: Minor
      Found in doc/yard/js/app.js - About 1 hr to fix

        Method build_error_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def build_error_message
      return nil if @response.nil?

      message = if response_body
        if response_body.respond_to?(:errors)
        Severity: Minor
        Found in lib/invoicexpress/error.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language