webcol/Calima

View on GitHub
public_/librerias/angular/js/core/sharedState.js

Summary

Maintainability
D
2 days
Test Coverage

File sharedState.js has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function() {
  'use strict';  
  var module = angular.module('mobile-angular-ui.core.sharedState', []);

  module.factory('SharedState', [
Severity: Minor
Found in public_/librerias/angular/js/core/sharedState.js - About 3 hrs to fix

    Function link has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          link: function ($scope, $element, $attr, ctrl, $transclude) {
              var block, childScope, previousElements, 
              exprFn = $parse($attr.uiIf),
              uiIfFn = function() { // can be slow
                return exprFn(angular.extend({}, SharedState.values(), $scope));
    Severity: Minor
    Found in public_/librerias/angular/js/core/sharedState.js - About 1 hr to fix

      Function initialize has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              initialize: function(scope, id, options) {
                options = options || {};
                
                var isNewScope = scopes[scope] === undefined,
                    defaultValue = options.defaultValue,
      Severity: Minor
      Found in public_/librerias/angular/js/core/sharedState.js - About 1 hr to fix

        Function uiIfWatchAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  $scope.$watch(uiIfFn, function uiIfWatchAction(value) {
                    if (value) {
                      if (!childScope) {
                        $transclude(function (clone, newScope) {
                          childScope = newScope;
        Severity: Minor
        Found in public_/librerias/angular/js/core/sharedState.js - About 1 hr to fix

          Function link has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                link: function ($scope, $element, $attr, ctrl, $transclude) {
          Severity: Minor
          Found in public_/librerias/angular/js/core/sharedState.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              module.directive('uiHide', ['$animate', 'SharedState', '$parse', function($animate, SharedState, $parse) {
                var NG_HIDE_CLASS = 'ng-hide';
                var NG_HIDE_IN_PROGRESS_CLASS = 'ng-hide-animate';
            
                return {
            Severity: Major
            Found in public_/librerias/angular/js/core/sharedState.js and 1 other location - About 6 hrs to fix
            public_/librerias/angular/js/core/sharedState.js on lines 308..327

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 162.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              module.directive('uiShow', ['$animate', 'SharedState', '$parse', function($animate, SharedState, $parse) {
                var NG_HIDE_CLASS = 'ng-hide';
                var NG_HIDE_IN_PROGRESS_CLASS = 'ng-hide-animate';
            
                return {
            Severity: Major
            Found in public_/librerias/angular/js/core/sharedState.js and 1 other location - About 6 hrs to fix
            public_/librerias/angular/js/core/sharedState.js on lines 286..305

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 162.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status