Sign upLogin

webcol/Calima

View on GitHub
Star
public_/librerias/flot/jquery.flot.fillbetween.js

Summary

Maintainability
D
2 days
Test Coverage

Function init has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function init( plot ) {

        function findBottomSeries( s, allseries ) {

            var i;
Severity: Major
Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 4 hrs to fix

    Function computeFillBottoms has 96 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function computeFillBottoms( plot, s, datapoints ) {

            if ( s.fillBetween == null ) {
                return;
            }
    Severity: Major
    Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 3 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                          if ( px === qx ) {

                        for ( m = 0; m < ps; ++m ) {
                            newpoints.push( points[ i + m ] );
                        }
      Severity: Major
      Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if ( l !== newpoints.length && withbottom ) {
                        newpoints[ l + 2 ] = bottom;
                    }
        Severity: Major
        Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              for ( m = 0; m < ps; ++m ) {
                        newpoints.push( null );
                    }
          Severity: Major
          Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    for ( m = 0; m < ps; ++m ) {
                            newpoints.push( points[ i + m ] );
                        }
            Severity: Major
            Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 45 mins to fix

              Consider simplifying this complex logical expression.
              Open

                              if ( withsteps && l !== newpoints.length && l > 0 &&
                    newpoints[ l ] !== null &&
                    newpoints[ l ] !== newpoints[ l - ps ] &&
                    newpoints[ l + 1 ] !== newpoints[ l - ps + 1 ] ) {
                    for (m = 0; m < ps; ++m) {
              Severity: Major
              Found in public_/librerias/flot/jquery.flot.fillbetween.js - About 40 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if ( withsteps && l !== newpoints.length && l > 0 &&
                    newpoints[ l ] !== null &&
                    newpoints[ l ] !== newpoints[ l - ps ] &&
                    newpoints[ l + 1 ] !== newpoints[ l - ps + 1 ] ) {
                    for (m = 0; m < ps; ++m) {
                Severity: Major
                Found in public_/librerias/flot/jquery.flot.fillbetween.js and 1 other location - About 2 hrs to fix
                public_/librerias/flot/jquery.flot.stack.js on lines 166..173

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 82.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                            bottom = qy + ( otherpoints[ j - otherps + 1 ] - qy ) * ( px - qx ) / ( otherpoints[ j - otherps ] - qx );
                Severity: Minor
                Found in public_/librerias/flot/jquery.flot.fillbetween.js and 1 other location - About 50 mins to fix
                public_/librerias/flot/jquery.flot.fillbetween.js on lines 157..157

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                            intery = py + ( points[ i - ps + 1 ] - py ) * ( qx - px ) / ( points[ i - ps ] - px );
                Severity: Minor
                Found in public_/librerias/flot/jquery.flot.fillbetween.js and 1 other location - About 50 mins to fix
                public_/librerias/flot/jquery.flot.fillbetween.js on lines 185..185

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status