webcomics/dosage

View on GitHub

Showing 64 of 581 total issues

File comicfury.py has 1146 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
# Copyright (C) 2012-2014 Bastian Kleineidam
# Copyright (C) 2015-2017 Tobias Gruetzmacher

Severity: Major
Found in dosagelib/plugins/comicfury.py - About 2 days to fix

    File smackjeeves.py has 713 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
    # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
    # Copyright (C) 2012-2014 Bastian Kleineidam
    # Copyright (C) 2015-2017 Tobias Gruetzmacher
    
    
    Severity: Major
    Found in dosagelib/plugins/smackjeeves.py - About 1 day to fix

      File old.py has 611 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # -*- coding: utf-8 -*-
      # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
      # Copyright (C) 2012-2014 Bastian Kleineidam
      # Copyright (C) 2015-2017 Tobias Gruetzmacher
      
      
      Severity: Major
      Found in dosagelib/plugins/old.py - About 1 day to fix

        File gocomics.py has 566 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
        # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
        # Copyright (C) 2012-2014 Bastian Kleineidam
        # Copyright (C) 2015-2018 Tobias Gruetzmacher
        
        
        Severity: Major
        Found in dosagelib/plugins/gocomics.py - About 1 day to fix

          File s.py has 479 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
          # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
          # Copyright (C) 2012-2014 Bastian Kleineidam
          # Copyright (C) 2015-2019 Tobias Gruetzmacher
          
          
          Severity: Minor
          Found in dosagelib/plugins/s.py - About 7 hrs to fix

            File scraper.py has 465 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
            # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
            # Copyright (C) 2012-2014 Bastian Kleineidam
            # Copyright (C) 2015-2019 Tobias Gruetzmacher
            
            
            Severity: Minor
            Found in dosagelib/scraper.py - About 7 hrs to fix

              File util.py has 419 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
              # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
              # Copyright (C) 2012-2014 Bastian Kleineidam
              # Copyright (C) 2015-2019 Tobias Gruetzmacher
              
              
              Severity: Minor
              Found in dosagelib/util.py - About 6 hrs to fix

                Function getScrapers has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
                Open

                def getScrapers(comics, basepath=None, adult=True, multiple_allowed=False, listing=False):
                    """Get scraper objects for the given comics."""
                    if '@' in comics:
                        # only scrapers whose directory already exists
                        if len(comics) > 1:
                Severity: Minor
                Found in dosagelib/director.py - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Scraper has 26 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class Scraper(object):
                    '''Base class for all comic scraper, but without a specific scrape
                    implementation.'''
                
                    # The URL for the comic strip
                Severity: Minor
                Found in dosagelib/scraper.py - About 3 hrs to fix

                  File events.py has 287 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
                  # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
                  # Copyright (C) 2012-2014 Bastian Kleineidam
                  # Copyright (C) 2015-2017 Tobias Gruetzmacher
                  
                  
                  Severity: Minor
                  Found in dosagelib/events.py - About 2 hrs to fix

                    File cmd.py has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # -*- coding: utf-8 -*-
                    # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
                    # Copyright (C) 2012-2014 Bastian Kleineidam
                    # Copyright (C) 2015-2019 Tobias Gruetzmacher
                    
                    
                    Severity: Minor
                    Found in dosagelib/cmd.py - About 2 hrs to fix

                      File c.py has 269 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # -*- coding: utf-8 -*-
                      # Copyright (C) 2004-2008 Tristan Seligmann and Jonathan Jacobs
                      # Copyright (C) 2012-2014 Bastian Kleineidam
                      # Copyright (C) 2015-2018 Tobias Gruetzmacher
                      
                      
                      Severity: Minor
                      Found in dosagelib/plugins/c.py - About 2 hrs to fix

                        Function getStripsFor has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def getStripsFor(self, url, maxstrips):
                                """Get comic strips for an URL. If maxstrips is a positive number, stop after
                                retrieving the given number of strips."""
                                self.hitFirstStripUrl = False
                                seen_urls = set()
                        Severity: Minor
                        Found in dosagelib/scraper.py - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function create_symlinks has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def create_symlinks(d):
                            """Create new symbolic links in output directory."""
                            data = loadJson(d)
                            outDir = prepare_output(d)
                        
                        
                        Severity: Minor
                        Found in scripts/order-symlinks.py - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function display_version has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def display_version(verbose):
                            """Display application name, version, copyright and license."""
                            print(configuration.App)
                            print(configuration.Copyright)
                            print(configuration.Freeware)
                        Severity: Minor
                        Found in dosagelib/cmd.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function _getStrips has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def _getStrips(self, scraperobj):
                                """Get all strips from a scraper."""
                                if self.options.all or self.options.cont:
                                    numstrips = None
                                elif self.options.numstrips:
                        Severity: Minor
                        Found in dosagelib/director.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function get_download_dir has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def get_download_dir(self, basepath):
                                """Try to find the corect download directory, ignoring case
                                differences."""
                                path = basepath
                                for part in self.name.split('/'):
                        Severity: Minor
                        Found in dosagelib/scraper.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function getStrips has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def getStrips(self, maxstrips=None):
                                """Get comic strips."""
                                if maxstrips:
                                    word = u"strip" if maxstrips == 1 else "strips"
                                    msg = u'Retrieving %d %s' % (maxstrips, word)
                        Severity: Minor
                        Found in dosagelib/scraper.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function find_scrapers has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def find_scrapers(comic, multiple_allowed=False):
                            """Get a list comic scraper objects.
                        
                            Can return more than one entry if multiple_allowed is True, else it raises
                            a ValueError if multiple modules match. The match is a case insensitive
                        Severity: Minor
                        Found in dosagelib/scraper.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function __init__ has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def __init__(self, flavor_id="", exit_code=-1):
                                """Create an exclusive lockfile or exit with an error and the given
                                exit code."""
                                self.initialized = False
                                scriptname = os.path.splitext(os.path.realpath(sys.argv[0]))[0]
                        Severity: Minor
                        Found in dosagelib/singleton.py - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language