Sign upLogin

website-scraper/node-website-scraper

View on GitHub
Star

Showing 4 of 5 total issues

Function createNewRequest has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    createNewRequest (resource) {
        const self = this;
        const url = resource.getUrl();

        const requestPromise = Promise.resolve()
Severity: Minor
Found in lib/scraper.js - About 1 hr to fix

    Function createNewRequest has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        createNewRequest (resource) {
        const self = this;
        const url = resource.getUrl();

        const requestPromise = Promise.resolve()
    Severity: Minor
    Found in lib/scraper.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function downloadChildrenResources has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        downloadChildrenResources (pathContainer, parentResource) {
        const self = this;
        const childrenPaths = pathContainer.getPaths();
        const pathsToUpdate = [];
    Severity: Minor
    Found in lib/resource-handler/index.js - About 1 hr to fix

      Function normalizeOptions has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          normalizeOptions (options) {
        this.options = extend(defaults, options);
        this.options.request = extend(defaults.request, options.request);

        const urls = Array.isArray(options.urls) ? options.urls : [options.urls];
      Severity: Minor
      Found in lib/scraper.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language