Sign upLogin

wenwei1202/passport-wechat-public

View on GitHub
Star

Showing 4 of 7 total issues

Function authenticate has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

WechatPublicStrategy.prototype.authenticate = function(req, options) {
  options = options || {}

  var self = this
    //user disapproved, in the wechat docs it says it won't have code when user disapproved, actually get code 'authdeny'
Severity: Minor
Found in lib/strategy.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function authenticate has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

WechatPublicStrategy.prototype.authenticate = function(req, options) {
  options = options || {}

  var self = this
    //user disapproved, in the wechat docs it says it won't have code when user disapproved, actually get code 'authdeny'
Severity: Major
Found in lib/strategy.js - About 3 hrs to fix

    Function verifyResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      function verifyResult(accessToken, refreshToken, params, profile, verified) {
    Severity: Minor
    Found in lib/strategy.js - About 35 mins to fix

      Function originalURL has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.originalURL = function(req, options) {
  options = options || {}
  var app = req.app
  if (app && app.get && app.get('trust proxy')) {
    options.proxy = true
      Severity: Minor
      Found in lib/utils.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language