Sign upLogin

whitef0x0/tellform

View on GitHub
Star
public/form_modules/forms/base/directives/submit-form.client.directive.js

Summary

Maintainability
D
3 days
Test Coverage

Function controller has 310 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            controller: function($document, $window, $scope){
                var NOSCROLL = false;
                var FORM_ACTION_ID = 'submit_field';
                $scope.forms = {};
Severity: Major
Found in public/form_modules/forms/base/directives/submit-form.client.directive.js - About 1 day to fix

    File submit-form.client.directive.js has 331 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

//FIXME: Should find an appropriate place for this
//Setting up jsep
jsep.addBinaryOp('contains', 10);
    Severity: Minor
    Found in public/form_modules/forms/base/directives/submit-form.client.directive.js - About 3 hrs to fix

      Function evaluateLogicJump has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      var evaluateLogicJump = function(field){
                    var logicJump = field.logicJump;

                    if(logicJump.enabled){
                        if (logicJump.expressionString && logicJump.valueB && field.fieldValue) {
      Severity: Major
      Found in public/form_modules/forms/base/directives/submit-form.client.directive.js - About 2 hrs to fix

        Function submitForm has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        $rootScope.submitForm = $scope.submitForm = function() {
                    if($scope.forms.myForm.$invalid){
                        $scope.goToInvalid();
                        return;
                    }
        Severity: Minor
        Found in public/form_modules/forms/base/directives/submit-form.client.directive.js - About 1 hr to fix

          Function setActiveField has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          $scope.setActiveField = $rootScope.setActiveField = function(field_id, field_index, animateScroll) {
                    if($scope.selected === null || (!field_id && field_index === null) )  {
                        return;
                    }
          Severity: Minor
          Found in public/form_modules/forms/base/directives/submit-form.client.directive.js - About 1 hr to fix

            Function onscroll has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                            $window.onscroll = function(){
                    if(!NOSCROLL){

                        var scrollTop = $(window).scrollTop();
                        var elemBox = document.getElementsByClassName('activeField')[0].getBoundingClientRect();
            Severity: Minor
            Found in public/form_modules/forms/base/directives/submit-form.client.directive.js - About 1 hr to fix

              FIXME found
              Open

              //FIXME: Should find an appropriate place for this
              Severity: Minor
              Found in public/form_modules/forms/base/directives/submit-form.client.directive.js by fixme

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      if($scope.myform.form_fields[i].fieldType === 'dropdown' && !$scope.myform.form_fields[i].deletePreserved){
                            $scope.myform.form_fields[i].fieldValue = $scope.myform.form_fields[i].fieldValue.option_value;
                        }
              Severity: Minor
              Found in public/form_modules/forms/base/directives/submit-form.client.directive.js and 1 other location - About 35 mins to fix
              public/modules/forms/admin/directives/edit-submissions-form.client.directive.js on lines 51..53

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if (md.tablet()){
                        deviceType = 'tablet';
                    } else if (md.mobile()) {
                        deviceType = 'mobile';
                    } else if (!md.is('bot')) {
              Severity: Minor
              Found in public/form_modules/forms/base/directives/submit-form.client.directive.js and 1 other location - About 35 mins to fix
              public/form_modules/forms/directives/analytics-service.client.directive.js on lines 23..29

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status