Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js

Summary

Maintainability
F
3 days
Test Coverage

Function pluralRuleParser has 341 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function pluralRuleParser(rule, number) {
    'use strict';

    /*
    Syntax: see http://unicode.org/reports/tr35/#Language_Plural_Rules
Severity: Major
Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js - About 1 day to fix

    File CLDRPluralRuleParser.js has 355 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * cldrpluralparser.js
 * A parser engine for CLDR plural rules.
 *
 * Copyright 2012-2014 Santhosh Thottingal and other contributors
    Severity: Minor
    Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function sequence(parserSyntax) {
        var i, parserRes,
            originalPos = pos,
            result = [];
      Severity: Major
      Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js and 1 other location - About 3 hrs to fix
      resources/lib/jquery.i18n/src/jquery.i18n.parser.js on lines 75..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function nOrMore(n, p) {
        return function() {
            var originalPos = pos,
                result = [],
                parsed = p();
      Severity: Major
      Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js and 1 other location - About 3 hrs to fix
      resources/lib/jquery.i18n/src/jquery.i18n.parser.js on lines 97..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          function choice(parserSyntax) {
        return function() {
            var i, result;

            for (i = 0; i < parserSyntax.length; i++) {
      Severity: Major
      Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js and 1 other location - About 2 hrs to fix
      resources/lib/jquery.i18n/src/jquery.i18n.parser.js on lines 56..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          function makeRegexParser(regex) {
        return function() {
            var matches = rule.substr(pos).match(regex);

            if (matches === null) {
      Severity: Major
      Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js and 2 other locations - About 1 hr to fix
      resources/lib/jquery.i18n/src/jquery.i18n.parser.js on lines 135..147
      resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js on lines 458..467

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (result !== null) {
            debug(' -- passed is :', result[0], ' == ', parseInt(result[4], 10));

            return result[0] === parseInt(result[4], 10);
        }
      Severity: Minor
      Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js and 1 other location - About 55 mins to fix
      resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js on lines 363..367

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (result !== null) {
            debug(' -- passed isnot: ', result[0], ' != ', parseInt(result[4], 10));

            return result[0] !== parseInt(result[4], 10);
        }
      Severity: Minor
      Found in resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js and 1 other location - About 55 mins to fix
      resources/lib/CLDRPluralRuleParser/CLDRPluralRuleParser.js on lines 346..350

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status