Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/lib/jquery.ui/jquery.ui.accordion.js

Summary

Maintainability
F
4 days
Test Coverage

File jquery.ui.accordion.js has 586 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery UI Accordion 1.9.2
 * http://jqueryui.com
 *
 * Copyright 2012 jQuery Foundation and other contributors
Severity: Major
Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 day to fix

    Function _create has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _create: function() {
        var accordionId = this.accordionId = "ui-accordion-" +
                (this.element.attr( "id" ) || ++uid),
            options = this.options;
    Severity: Major
    Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 3 hrs to fix

      Function _animate has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _animate: function( toShow, toHide, data ) {
        var total, easing, duration,
            that = this,
            adjust = 0,
            down = toShow.length &&
      Severity: Minor
      Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 hr to fix

        Function _eventHandler has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _eventHandler: function( event ) {
        var options = this.options,
            active = this.active,
            clicked = $( event.currentTarget ),
            clickedIsActive = clicked[ 0 ] === active[ 0 ],
        Severity: Minor
        Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 hr to fix

          Function refresh has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              refresh: function() {
        var maxHeight, overflow,
            heightStyle = this.options.heightStyle,
            parent = this.element.parent();
          Severity: Minor
          Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 hr to fix

            Function _toggle has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _toggle: function( data ) {
        var toShow = data.newPanel,
            toHide = this.prevShow.length ? this.prevShow : data.oldPanel;

        // handle activating a panel during the animation for another activation
            Severity: Minor
            Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 hr to fix

              Function _keydown has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  _keydown: function( event ) {
        if ( event.altKey || event.ctrlKey ) {
            return;
        }
              Severity: Minor
              Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 hr to fix

                Function _destroy has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    _destroy: function() {
        var contents;

        // clean up main element
        this.element
                Severity: Minor
                Found in resources/lib/jquery.ui/jquery.ui.accordion.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              this.element.siblings( ":visible" ).each(function() {
                var elem = $( this ),
                    position = elem.css( "position" );

                if ( position === "absolute" || position === "fixed" ) {
                  Severity: Major
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 2 hrs to fix
                  resources/lib/jquery.ui/jquery.ui.tabs.js on lines 508..516

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 87.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if ( toShow.length && toHide.length ) {
            toHide.prev().attr( "tabIndex", -1 );
        } else if ( toShow.length ) {
            this.headers.filter(function() {
                return $( this ).attr( "tabIndex" ) === 0;
                  Severity: Major
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 1 hr to fix
                  resources/lib/jquery.ui/jquery.ui.tabs.js on lines 629..636

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              this.headers.next()
                .each(function() {
                    $( this ).height( Math.max( 0, maxHeight -
                        $( this ).innerHeight() + $( this ).height() ) );
                })
                  Severity: Major
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 1 hr to fix
                  resources/lib/jquery.ui/jquery.ui.tabs.js on lines 525..528

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 61.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if ( type === "beforeActivate" ) {
                ret = _trigger.call( this, "changestart", event, {
                    oldHeader: data.oldHeader,
                    oldContent: data.oldPanel,
                    newHeader: data.newHeader,
                  Severity: Major
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 1 hr to fix
                  resources/lib/jquery.ui/jquery.ui.accordion.js on lines 684..691

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 59.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              } else if ( type === "activate" ) {
                ret = _trigger.call( this, "change", event, {
                    oldHeader: data.oldHeader,
                    oldContent: data.oldPanel,
                    newHeader: data.newHeader,
                  Severity: Major
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 1 hr to fix
                  resources/lib/jquery.ui/jquery.ui.accordion.js on lines 677..691

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 59.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if ( options.icons ) {
                clicked.children( ".ui-accordion-header-icon" )
                    .removeClass( options.icons.header )
                    .addClass( options.icons.activeHeader );
            }
                  Severity: Minor
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 55 mins to fix
                  resources/lib/jquery.ui/jquery.ui.accordion.js on lines 402..406

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          if ( options.icons ) {
            active.children( ".ui-accordion-header-icon" )
                .removeClass( options.icons.activeHeader )
                .addClass( options.icons.header );
        }
                  Severity: Minor
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 55 mins to fix
                  resources/lib/jquery.ui/jquery.ui.accordion.js on lines 412..416

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if ( !$.support.minHeight ) {
                overflow = parent.css( "overflow" );
                parent.css( "overflow", "hidden");
            }
                  Severity: Minor
                  Found in resources/lib/jquery.ui/jquery.ui.accordion.js and 1 other location - About 40 mins to fix
                  resources/lib/jquery.ui/jquery.ui.tabs.js on lines 503..506

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status