Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/lib/jquery.ui/jquery.ui.button.js

Summary

Maintainability
D
1 day
Test Coverage

Function _create has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _create: function() {
        this.element.closest( "form" )
            .off( "reset" + this.eventNamespace )
            .on( "reset" + this.eventNamespace, formResetHandler );
Severity: Major
Found in resources/lib/jquery.ui/jquery.ui.button.js - About 5 hrs to fix

    File jquery.ui.button.js has 354 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * jQuery UI Button 1.9.2
 * http://jqueryui.com
 *
 * Copyright 2012 jQuery Foundation and other contributors
    Severity: Minor
    Found in resources/lib/jquery.ui/jquery.ui.button.js - About 4 hrs to fix

      Function _resetButton has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _resetButton: function() {
        if ( this.type === "input" ) {
            if ( this.options.label ) {
                this.element.val( this.options.label );
            }
      Severity: Minor
      Found in resources/lib/jquery.ui/jquery.ui.button.js - About 1 hr to fix

        Function _determineButtonType has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _determineButtonType: function() {
        var ancestor, labelSelector, checked;

        if ( this.element.is("[type=checkbox]") ) {
            this.type = "checkbox";
        Severity: Minor
        Found in resources/lib/jquery.ui/jquery.ui.button.js - About 1 hr to fix

          Function refresh has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              refresh: function() {
        //See #8237 & #8828
        var isDisabled = this.element.is( "input, button" ) ? this.element.is( ":disabled" ) : this.element.hasClass( "ui-button-disabled" );

        if ( isDisabled !== this.options.disabled ) {
          Severity: Minor
          Found in resources/lib/jquery.ui/jquery.ui.button.js - About 1 hr to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                                if ( event.keyCode === $.ui.keyCode.SPACE || event.keyCode === $.ui.keyCode.ENTER ) {
                        $( this ).addClass( "ui-state-active" );
                    }
            Severity: Major
            Found in resources/lib/jquery.ui/jquery.ui.button.js and 5 other locations - About 35 mins to fix
            resources/lib/ooui/oojs-ui-core.js on lines 7435..7435
            resources/lib/ooui/oojs-ui-core.js on lines 9585..9589
            resources/lib/ooui/oojs-ui-core.js on lines 9587..9589
            resources/lib/ooui/oojs-ui-widgets.js on lines 4172..4196
            resources/lib/ooui/oojs-ui-widgets.js on lines 4538..4560

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status