File jquery.ui.dialog.js
has 676 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*!
* jQuery UI Dialog 1.9.2
* http://jqueryui.com
*
* Copyright 2012 jQuery Foundation and other contributors
Function _create
has 103 lines of code (exceeds 25 allowed). Consider refactoring. Open
_create: function() {
this.originalTitle = this.element.attr( "title" );
// #5742 - .attr() might return a DOMElement
if ( typeof this.originalTitle !== "string" ) {
this.originalTitle = "";
Function _setOption
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
_setOption: function( key, value ) {
var isDraggable, isResizable,
uiDialog = this.uiDialog;
switch ( key ) {
Function _makeResizable
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
_makeResizable: function( handles ) {
handles = (handles === undefined ? this.options.resizable : handles);
var that = this,
options = this.options,
// .ui-resizable has position: relative defined in the stylesheet
Function _size
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
_size: function() {
/* If the user has resized the dialog, the .ui-dialog and .ui-dialog-content
* divs will both have width and height set, so we need to reset them
*/
var nonContentHeight, minContentHeight, autoHeight,
Function close
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
close: function( event ) {
var that = this,
maxZ, thisZ;
if ( !this._isOpen ) {
Function _position
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
_position: function( position ) {
var myAt = [],
offset = [ 0, 0 ],
isVisible;
Function create
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
create: function( dialog ) {
if ( this.instances.length === 0 ) {
// prevent use of anchors and inputs
// we use a setTimeout in case the overlay is created from an
// event that we're going to be cancelling (see #2804)
Function _createButtons
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
_createButtons: function( buttons ) {
var that = this,
hasButtons = false;
// if we already have a button pane, remove it
Function _makeDraggable
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
_makeDraggable: function() {
var that = this,
options = this.options;
function filteredUi( ui ) {
Consider simplifying this complex logical expression. Open
if ( instances.length !== 0 && instances[ instances.length - 1 ] === $el &&
dialog.options.closeOnEscape && !event.isDefaultPrevented() && event.keyCode &&
event.keyCode === $.ui.keyCode.ESCAPE ) {
dialog.close( event );
Similar blocks of code found in 2 locations. Consider refactoring. Open
height: function() {
var scrollHeight,
offsetHeight;
// handle IE
if ( $.ui.ie ) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 165.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
width: function() {
var scrollWidth,
offsetWidth;
// handle IE
if ( $.ui.ie ) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 165.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76