wikimedia/mediawiki-core

View on GitHub
resources/lib/jquery.ui/jquery.ui.tabs.js

Summary

Maintainability
F
1 wk
Test Coverage

File jquery.ui.tabs.js has 1064 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery UI Tabs 1.9.2
 * http://jqueryui.com
 *
 * Copyright 2012 jQuery Foundation and other contributors
Severity: Major
Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 2 days to fix

    Function _create has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _create: function() {
            var that = this,
                options = this.options,
                active = options.active,
                locationHash = location.hash.substring( 1 );
    Severity: Major
    Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 2 hrs to fix

      Function _processTabs has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _processTabs: function() {
              var that = this;
      
              this.tablist = this._getList()
                  .addClass( "ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all" )
      Severity: Major
      Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 2 hrs to fix

        Function _toggle has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _toggle: function( event, eventData ) {
                var that = this,
                    toShow = eventData.newPanel,
                    toHide = eventData.oldPanel;
        
        
        Severity: Minor
        Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

          Function _tabKeydown has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _tabKeydown: function( event ) {
                  var focusedTab = $( this.document[0].activeElement ).closest( "li" ),
                      selectedIndex = this.tabs.index( focusedTab ),
                      goingForward = true;
          
          
          Severity: Minor
          Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

            Function _destroy has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _destroy: function() {
                    if ( this.xhr ) {
                        this.xhr.abort();
                    }
            
            
            Severity: Minor
            Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

              Function add has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      add: function( url, label, index ) {
                          if ( index === undefined ) {
                              index = this.anchors.length;
                          }
              
              
              Severity: Minor
              Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

                Function load has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    load: function( index, event ) {
                        index = this._getIndex( index );
                        var that = this,
                            tab = this.tabs.eq( index ),
                            anchor = tab.find( ".ui-tabs-anchor" ),
                Severity: Minor
                Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

                  Function _eventHandler has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      _eventHandler: function( event ) {
                          var options = this.options,
                              active = this.active,
                              anchor = $( event.currentTarget ),
                              tab = anchor.closest( "li" ),
                  Severity: Minor
                  Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

                    Function _toggle has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            _toggle: function( event, eventData ) {
                                var that = this,
                                    toShow = eventData.newPanel,
                                    toHide = eventData.oldPanel,
                                    fx = this._getFx();
                    Severity: Minor
                    Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

                      Function _setupHeightStyle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          _setupHeightStyle: function( heightStyle ) {
                              var maxHeight, overflow,
                                  parent = this.element.parent();
                      
                              if ( heightStyle === "fill" ) {
                      Severity: Minor
                      Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

                        Function _refresh has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            _refresh: function() {
                                this._setupDisabled( this.options.disabled );
                                this._setupEvents( this.options.event );
                                this._setupHeightStyle( this.options.heightStyle );
                        
                        
                        Severity: Minor
                        Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 1 hr to fix

                          Consider simplifying this complex logical expression.
                          Open

                                  if ( tab.hasClass( "ui-state-disabled" ) ||
                                          // tab is already loading
                                          tab.hasClass( "ui-tabs-loading" ) ||
                                          // can't switch durning an animation
                                          this.running ||
                          Severity: Major
                          Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 40 mins to fix

                            Consider simplifying this complex logical expression.
                            Open

                            if ( $.uiBackCompat !== false ) {
                            
                                // helper method for a lot of the back compat extensions
                                $.ui.tabs.prototype._ui = function( tab, panel ) {
                                    return {
                            Severity: Major
                            Found in resources/lib/jquery.ui/jquery.ui.tabs.js - About 40 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      enable: function( index ) {
                                          var options = this.options,
                                              trigger;
                              
                                          if ( index && options.disabled === true ||
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 5 hrs to fix
                              resources/lib/jquery.ui/jquery.ui.tabs.js on lines 994..1008

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 146.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      disable: function( index ) {
                                          var options = this.options,
                                              trigger;
                              
                                          if ( index && options.disabled === false ||
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 5 hrs to fix
                              resources/lib/jquery.ui/jquery.ui.tabs.js on lines 978..992

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 146.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          this.element.siblings( ":visible" ).each(function() {
                                              var elem = $( this ),
                                                  position = elem.css( "position" );
                              
                                              if ( position === "absolute" || position === "fixed" ) {
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 2 hrs to fix
                              resources/lib/jquery.ui/jquery.ui.accordion.js on lines 301..309

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 87.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( event.altKey && event.keyCode === $.ui.keyCode.PAGE_DOWN ) {
                                          this._activate( this._focusNextTab( this.options.active + 1, true ) );
                                          return true;
                                      }
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 1 hr to fix
                              resources/lib/jquery.ui/jquery.ui.tabs.js on lines 225..228

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 70.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( event.altKey && event.keyCode === $.ui.keyCode.PAGE_UP ) {
                                          this._activate( this._focusNextTab( this.options.active - 1, false ) );
                                          return true;
                                      }
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 1 hr to fix
                              resources/lib/jquery.ui/jquery.ui.tabs.js on lines 229..232

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 70.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( toShow.length && toHide.length ) {
                                          eventData.oldTab.attr( "tabIndex", -1 );
                                      } else if ( toShow.length ) {
                                          this.tabs.filter(function() {
                                              return $( this ).attr( "tabIndex" ) === 0;
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 1 hr to fix
                              resources/lib/jquery.ui/jquery.ui.accordion.js on lines 449..456

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 62.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          this.panels.each(function() {
                                              $( this ).height( Math.max( 0, maxHeight -
                                                  $( this ).innerHeight() + $( this ).height() ) );
                                          })
                              Severity: Major
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 1 hr to fix
                              resources/lib/jquery.ui/jquery.ui.accordion.js on lines 318..322

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 61.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      this.anchors
                                          .removeClass( "ui-tabs-anchor" )
                                          .removeAttr( "role" )
                                          .removeAttr( "tabIndex" )
                                          .removeData( "href.tabs" )
                              Severity: Minor
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 50 mins to fix
                              resources/lib/jquery.ui/jquery.ui.menu.js on lines 152..157

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 52.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                          if ( !$.support.minHeight ) {
                                              overflow = parent.css( "overflow" );
                                              parent.css( "overflow", "hidden");
                                          }
                              Severity: Minor
                              Found in resources/lib/jquery.ui/jquery.ui.tabs.js and 1 other location - About 40 mins to fix
                              resources/lib/jquery.ui/jquery.ui.accordion.js on lines 296..299

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 49.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status