wikimedia/mediawiki-core

View on GitHub
resources/lib/jquery.ui/jquery.ui.widget.js

Summary

Maintainability
D
2 days
Test Coverage

File jquery.ui.widget.js has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jQuery UI Widget 1.9.2
 * http://jqueryui.com
 *
 * Copyright 2012 jQuery Foundation and other contributors
Severity: Minor
Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 5 hrs to fix

    Function widget has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    $.widget = function( name, base, prototype ) {
        var fullName, existingConstructor, constructor, basePrototype,
            namespace = name.split( "." )[ 0 ];
    
        name = name.split( "." )[ 1 ];
    Severity: Major
    Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 2 hrs to fix

      Function bridge has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      $.widget.bridge = function( name, object ) {
          var fullName = object.prototype.widgetFullName || name;
          $.fn[ name ] = function( options ) {
              var isMethodCall = typeof options === "string",
                  args = slice.call( arguments, 1 ),
      Severity: Minor
      Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 1 hr to fix

        Function _on has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _on: function( suppressDisabledCheck, element, handlers ) {
                var delegateElement,
                    instance = this;
        
                // no suppressDisabledCheck flag, shuffle arguments
        Severity: Minor
        Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 1 hr to fix

          Function name has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              $.fn[ name ] = function( options ) {
                  var isMethodCall = typeof options === "string",
                      args = slice.call( arguments, 1 ),
                      returnValue = this;
          
          
          Severity: Minor
          Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 1 hr to fix

            Function option has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                option: function( key, value ) {
                    var options = key,
                        parts,
                        curOption,
                        i;
            Severity: Minor
            Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 1 hr to fix

              Function _createWidget has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  _createWidget: function( options, element ) {
                      element = $( element || this.defaultElement || this )[ 0 ];
                      this.element = $( element );
                      this.uuid = uuid++;
                      this.eventNamespace = "." + this.widgetName + this.uuid;
              Severity: Minor
              Found in resources/lib/jquery.ui/jquery.ui.widget.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    _hoverable: function( element ) {
                        this.hoverable = this.hoverable.add( element );
                        this._on( element, {
                            mouseenter: function( event ) {
                                $( event.currentTarget ).addClass( "ui-state-hover" );
                Severity: Major
                Found in resources/lib/jquery.ui/jquery.ui.widget.js and 1 other location - About 3 hrs to fix
                resources/lib/jquery.ui/jquery.ui.widget.js on lines 443..453

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    _focusable: function( element ) {
                        this.focusable = this.focusable.add( element );
                        this._on( element, {
                            focusin: function( event ) {
                                $( event.currentTarget ).addClass( "ui-state-focus" );
                Severity: Major
                Found in resources/lib/jquery.ui/jquery.ui.widget.js and 1 other location - About 3 hrs to fix
                resources/lib/jquery.ui/jquery.ui.widget.js on lines 431..441

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status