wikimedia/mediawiki-core

View on GitHub
resources/lib/moment/locale/is.js

Summary

Maintainability
D
1 day
Test Coverage

Function translate has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function translate(number, withoutSuffix, key, isFuture) {
        var result = number + ' ';
        switch (key) {
            case 's':
                return withoutSuffix || isFuture
Severity: Major
Found in resources/lib/moment/locale/is.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

                    return result + 'klukkustund';
    Severity: Major
    Found in resources/lib/moment/locale/is.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                          return result + (isFuture ? 'mánuði' : 'mánuðum');
      Severity: Major
      Found in resources/lib/moment/locale/is.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return isFuture ? 'mánuð' : 'mánuði';
        Severity: Major
        Found in resources/lib/moment/locale/is.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return isFuture ? 'dag' : 'degi';
          Severity: Major
          Found in resources/lib/moment/locale/is.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                return result + (isFuture ? 'daga' : 'dögum');
            Severity: Major
            Found in resources/lib/moment/locale/is.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return result + 'mínútu';
              Severity: Major
              Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                    return result + 'mánuður';
                Severity: Major
                Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return result + (isFuture ? 'dag' : 'degi');
                  Severity: Major
                  Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return result + (withoutSuffix || isFuture ? 'ár' : 'ári');
                    Severity: Major
                    Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return 'mánuður';
                      Severity: Major
                      Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                            return result + (withoutSuffix || isFuture ? 'ár' : 'árum');
                        Severity: Major
                        Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return 'dagur';
                          Severity: Major
                          Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return result + (isFuture ? 'mánuð' : 'mánuði');
                            Severity: Major
                            Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                  return (
                                                      result +
                                                      (withoutSuffix || isFuture
                                                          ? 'klukkustundir'
                                                          : 'klukkustundum')
                              Severity: Major
                              Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                        return result + 'dagar';
                                Severity: Major
                                Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                                      return result + 'dagur';
                                  Severity: Major
                                  Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                                            return result + 'mánuðir';
                                    Severity: Major
                                    Found in resources/lib/moment/locale/is.js - About 30 mins to fix

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  case 'dd':
                                                      if (plural(number)) {
                                                          if (withoutSuffix) {
                                                              return result + 'dagar';
                                                          }
                                      Severity: Major
                                      Found in resources/lib/moment/locale/is.js and 1 other location - About 1 hr to fix
                                      resources/lib/moment/locale/is.js on lines 78..87

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 70.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                  case 'MM':
                                                      if (plural(number)) {
                                                          if (withoutSuffix) {
                                                              return result + 'mánuðir';
                                                          }
                                      Severity: Major
                                      Found in resources/lib/moment/locale/is.js and 1 other location - About 1 hr to fix
                                      resources/lib/moment/locale/is.js on lines 63..72

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 70.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status