wikimedia/mediawiki-core

File oojs.js has 693 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*!
 * OOjs v7.0.1
 * https://www.mediawiki.org/wiki/OOjs
 *
 * Copyright 2011-2023 OOjs Team and other contributors.

Function emitThrow has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    OO.EventEmitter.prototype.emitThrow = function ( event ) {
        // We tolerate code duplication with #emit, because the
        // alternative is an extra level of indirection which will
        // appear in very many stack traces.
        if ( !hasOwn.call( this.bindings, event ) ) {

Function aggregate has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    OO.EmitterList.prototype.aggregate = function ( events ) {
        var i, item;
        for ( var itemEvent in events ) {
            var groupEvent = events[ itemEvent ];

Function emit has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    OO.EventEmitter.prototype.emit = function ( event ) {
        if ( !hasOwn.call( this.bindings, event ) ) {
            return false;
        }

Function compare has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

OO.compare = function ( a, b, asymmetrical ) {
    if ( a === b ) {
        return true;
    }

Consider simplifying this complex logical expression.

Open

        if ( aType !== bType ||
            (
                ( aType === 'string' || aType === 'number' || aType === 'boolean' ) &&
                aValue !== bValue
            ) ||

Avoid too many return statements within this function.

Open

    return destination;

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if ( typeof binding.method === 'string' ) {
                // Lookup method by name (late binding)
                method = binding.context[ binding.method ];
            } else {
                method = binding.method;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if ( typeof binding.method === 'string' ) {
                // Lookup method by name (late binding)
                method = binding.context[ binding.method ];
            } else {
                method = binding.method;

• Read up
  Read up