Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/lib/ooui/oojs-ui-wikimediaui.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function getElementClasses has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

OO.ui.WikimediaUITheme.prototype.getElementClasses = function ( element ) {
    const
        variants = {
            invert: false,
            progressive: false,
Severity: Major
Found in resources/lib/ooui/oojs-ui-wikimediaui.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            } else if ( !element.isDisabled() ) {
            // Any other kind of button, use the right colored icon / indicator if available.
            variants.progressive = element.hasFlag( 'progressive' ) ||
                // Active tools/toolgroups
                ( isToolOrGroup && isActive ) ||
    Severity: Critical
    Found in resources/lib/ooui/oojs-ui-wikimediaui.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if (
            // Button with a dark background.
            isFramed && ( isActive || element.isDisabled() || element.hasFlag( 'primary' ) ) ||
            // Toolbar with a dark background.
            isToolOrGroup && element.hasFlag( 'primary' )
      Severity: Major
      Found in resources/lib/ooui/oojs-ui-wikimediaui.js - About 40 mins to fix

        Consider simplifying this complex logical expression.
        Open

            } else if ( element.supports( 'hasFlag' ) ) {
        const isFramed = element.supports( 'isFramed' ) && element.isFramed();
        const isActive = element.supports( 'isActive' ) && element.isActive();
        const isToolOrGroup =
            // Check if the class exists, as classes that are not in the 'core' module may
        Severity: Major
        Found in resources/lib/ooui/oojs-ui-wikimediaui.js - About 40 mins to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          OO.ui.WikimediaUITheme = function OoUiWikimediaUITheme() {
    // Parent constructor
    OO.ui.WikimediaUITheme.super.call( this );
};
          Severity: Major
          Found in resources/lib/ooui/oojs-ui-wikimediaui.js and 2 other locations - About 50 mins to fix
          resources/lib/ooui/oojs-ui-apex.js on lines 21..24
          resources/lib/ooui/oojs-ui-toolbars.js on lines 1491..1494

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status