wikimedia/mediawiki-core

View on GitHub
resources/lib/url/URL.js

Summary

Maintainability
D
2 days
Test Coverage

File URL.js has 455 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* global Symbol */
// URL Polyfill
// Draft specification: https://url.spec.whatwg.org

// Notes:
Severity: Minor
Found in resources/lib/url/URL.js - About 6 hrs to fix

    Function URL has 145 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            function URL(url, base) {
                if (!(this instanceof global.URL))
                    throw new TypeError("Failed to construct 'URL': Please use the 'new' operator.");
    
                if (base) {
    Severity: Major
    Found in resources/lib/url/URL.js - About 5 hrs to fix

      Function URLSearchParams has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function URLSearchParams(init) {
                  var $this = this;
                  this._list = [];
      
                  if (init === undefined || init === null) {
      Severity: Minor
      Found in resources/lib/url/URL.js - About 1 hr to fix

        Function urlencoded_parse has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                function urlencoded_parse(input, isindex) {
                    var sequences = input.split('&');
                    if (isindex && sequences[0].indexOf('=') === -1)
                        sequences[0] = '=' + sequences[0];
                    var pairs = [];
        Severity: Minor
        Found in resources/lib/url/URL.js - About 1 hr to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          password: {
                              get: function () { return instance.password; },
                              set: function (v) { instance.password = v; },
                              enumerable: true, configurable: true
                          },
          Severity: Major
          Found in resources/lib/url/URL.js and 4 other locations - About 1 hr to fix
          resources/lib/url/URL.js on lines 460..464
          resources/lib/url/URL.js on lines 465..469
          resources/lib/url/URL.js on lines 484..488
          resources/lib/url/URL.js on lines 489..493

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          hostname: {
                              get: function () { return instance.hostname; },
                              set: function (v) { instance.hostname = v; },
                              enumerable: true, configurable: true
                          },
          Severity: Major
          Found in resources/lib/url/URL.js and 4 other locations - About 1 hr to fix
          resources/lib/url/URL.js on lines 460..464
          resources/lib/url/URL.js on lines 465..469
          resources/lib/url/URL.js on lines 470..474
          resources/lib/url/URL.js on lines 489..493

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          protocol: {
                              get: function () { return instance.protocol; },
                              set: function (v) { instance.protocol = v; },
                              enumerable: true, configurable: true
                          },
          Severity: Major
          Found in resources/lib/url/URL.js and 4 other locations - About 1 hr to fix
          resources/lib/url/URL.js on lines 465..469
          resources/lib/url/URL.js on lines 470..474
          resources/lib/url/URL.js on lines 484..488
          resources/lib/url/URL.js on lines 489..493

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          port: {
                              get: function () { return instance.port; },
                              set: function (v) { instance.port = v; },
                              enumerable: true, configurable: true
                          },
          Severity: Major
          Found in resources/lib/url/URL.js and 4 other locations - About 1 hr to fix
          resources/lib/url/URL.js on lines 460..464
          resources/lib/url/URL.js on lines 465..469
          resources/lib/url/URL.js on lines 470..474
          resources/lib/url/URL.js on lines 484..488

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

                          username: {
                              get: function () { return instance.username; },
                              set: function (v) { instance.username = v; },
                              enumerable: true, configurable: true
                          },
          Severity: Major
          Found in resources/lib/url/URL.js and 4 other locations - About 1 hr to fix
          resources/lib/url/URL.js on lines 460..464
          resources/lib/url/URL.js on lines 470..474
          resources/lib/url/URL.js on lines 484..488
          resources/lib/url/URL.js on lines 489..493

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status